If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Enum arithmetic in nsRenderingContextGTK.cpp causing problems

RESOLVED FIXED

Status

()

Core
XUL
P3
normal
RESOLVED FIXED
18 years ago
18 years ago

People

(Reporter: tor, Assigned: Stuart Parmenter)

Tracking

Trunk
Sun
Solaris
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

18 years ago
SUNWspro5.0 doesn't like doing bitwise arithmetic with enums which
nsRenderingContextGtk::UpdateGC() is currently doing.  This patch
flips the types around to keep picky compilers happy:

Index: nsRenderingContextGTK.cpp
===================================================================
RCS file: /cvsroot/mozilla/gfx/src/gtk/nsRenderingContextGTK.cpp,v
retrieving revision 1.94
diff -u -r1.94 nsRenderingContextGTK.cpp
--- nsRenderingContextGTK.cpp   2000/01/28 23:52:28     1.94
+++ nsRenderingContextGTK.cpp   2000/01/29 05:44:21
@@ -492,7 +492,7 @@
 void nsRenderingContextGTK::UpdateGC()
 {
   GdkGCValues values;
-  GdkGCValuesMask valuesMask;
+  unsigned valuesMask;
 
   values.font = mCurrentFont;
   values.foreground.pixel =
gdk_rgb_xpixel_from_rgb(NS_TO_GDK_RGB(mCurrentColor));
@@ -514,7 +514,7 @@
 
   mGC = gcCache->GetClipGC(mSurface->GetDrawable(), 
                            &values,
-                           valuesMask,
+                           (GdkGCValuesMask)valuesMask,
                            rgn);
(Assignee)

Comment 1

18 years ago
patch checked in
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 2

18 years ago
please ignore, massive spam giving jrgm@netscape.com backlog of XPToolkits
resolved fixed bugs to verify
QA Contact: paulmac → jrgm
You need to log in before you can comment on or make changes to this bug.