25629 - [REGRESSION]Mac stores components as absolute paths

Status: VERIFIED FIXED

(Core :: XPCOM, defect, P1)

Description

[Doug Turner (:dougt)]

open up the component registry, and look at the file locations.  all are 
|abs:|.

Comment 1

[Doug Turner (:dougt)]

This blocks the installer.


sdagley, I believe the problem is with your Contains() function.  

Comment 2

[Samir Gehani]

Adding 25569 to the list of bugs that depend on this being resolved. Per dougt's 
investigation of the installer horkage this bug is a blocker for the Mac 
installer.

Comment 3

[Steve Dagley]

Actually I suspect the problem is in GetPath() rather than Contains() as one of 
the fixes I'm already working on is the distinction between the path and target.

This brings up a more fundamental question:  Where are these relative paths for 
the registry supposed to come from?  You have to initialize nsLocalFile with an 
absolute path (or FSSpec on the Mac) and the only thing that you're going to get 
back from that is an absolute path.  Or am I missing something here?

Comment 4

[Steve Dagley]

Ignore that last comment.  dougt explained to me what he meant by a problem in 
the Contains() function so now the problem makes sense.  I'll be looking at it 
once my build finishes.

Comment 5

[Steve Dagley]

Well I thought I had it fixed but before I could test my changes my spiffy new G4 
crashed.  Now it refuses to boot and it looks like I'm gonna have to reformat the 
@#$%^ hard drive.

Comment 6

[Doug Turner (:dougt)]

Robert, could you give us a hand?

Comment 7

[Steve Dagley]

I don't think rjc could do much for us as the fix involves adding the additional 
FSSpec to distinguish between the resolved and target objects and without being 
familiar with the code that wouldn't be immediately obvious.  In the AM I'll 
reformat and rebuild things and expect to be back to where I was today by early 
afternoon.

BTW, I was talking to sfraser about the tests in Contains() and now I'm thinking 
we only need 2 tests - path of |this| against the path of |inFile| and only test 
against target if |inFIle| is a sym link

Comment 8

[Steve Dagley]

This is now working but doesn't have the revisions to Contains() to exhaustively 
evaluate all possible path and target combinations

Comment 9

[leger]

Putting on PDT+ radar for beta1.

Comment 10

[leger]

Due to last sdagley comments, does not seem like this is Resolved completely 
yet.  If it is, please indicate as so.

Comment 11

[leger]

Moving [DOGFOOD} in Summary to "dogfood" in keyword field.

Comment 12

[Steve Dagley]

It's fixed.  The functionality of Contains() could be improved, on all platforms, 
but it is no longer causing a problem on Mac.

Comment 13

[leger]

Marking Verified per last comments.

Comment 14

[leger]

Marking Verified per last comments.