256508 - uxwrap: Poll() on OpenBSD 3.5

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Julien]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; fr-FR; rv:1.7.2) Gecko/20040803
Build Identifier: rv:1.7.2 & 1.8alpha3

Compilation problem:
uxwrap (3.14)
The poll() declaration doesn't correspond with /usr/include/sys/poll.h
348: int poll(struct pollfd *filedes, int nfsds, int timeout)
should be as for NETBSD:
348: int poll(struct pollfd *filedes, nfsds_t nfsds, int timeout)
OPENBSD 3.5/gcc 2.95.3/i386

Reproducible: Always
Steps to Reproduce:

Comment 1

[Wan-Teh Chang]

Darin, could you take care of this?

Julien: does OpenBSD have a pthread library now? If so,
you can try configure NSPR with --with-pthreads to work
around this problem.

Comment 2

[Julien]

The file is: nsprpub/pr/src/md/unix/uxwrap.c

There is a pthread lib.
with the option --with-pthreads it seems to work. libnspr4.a compiles fine

Comment 3

[Wan-Teh Chang]

If there is a pthread library, we recommend that you
use it (i.e., configure NSPR with --with-pthreads).
In any case, we will check in the simple fix for
uxwrap.c.

Comment 4

[Darin Fisher]

The existing code must have been valid on some version of OpenBSD, right?  If
so, then don't we still need to support the older versions?  If not, then
yeah... the patch is pretty trivial.  But, if otherwise, can someone suggest a
patch?  I don't have access to any OpenBSD systems.

Comment 5

[Jim Rees]

I'm got firefox 1.0 RC1 running on OpenBSD 3.3 with --with-pthreads. That's
about the oldest version of OpenBSD anyone is likely to run this code on, so I
don't think we need to make the non-pthreads code work.

Comment 6

[Wan-Teh Chang]

Attachment: Make --with-pthreads the default

Given comment 2 and comment 5, I think it is not worth
it to fix uxwrap.c.  Instead, we should make --with-pthreads
the default for OpenBSD.

Could you test this patch?  After you apply this patch,
you need to run autoconf (2.13, not 2.5x) in mozilla/nsprpub
to regenerate mozilla/nsprpub/configure.  Thanks.

Comment 7

[Wan-Teh Chang]

Jim, Julien, could you test my patch?

Comment 8

[Jim Rees]

Your patch works for me on OpenBSD 3.6. I recommend also patching
nsprpub/configure and then commit.

Comment 9

[Wan-Teh Chang]

Marked the bug WONTFIX because I didn't fix the
uxwrap.c problem originally reported.

Instead, I checked in a patch on the NSPR tip
(NSPR 4.6) and NSPRPUB_PRE_4_2_CLIENT_BRANCH
(Mozilla 1.8 Beta 2) to make --with-pthreads
the default on OpenBSD.  If pthreads are used,
we do not compile the code in uxwrap.c.

Comment 10

[Jim Rees]

You may want to also mark Bug 269591 as resolved/wontfix. It's a duplicate of
this bug.

Comment 11

[Wan-Teh Chang]

*** Bug 269591 has been marked as a duplicate of this bug. ***

Comment 12

[Wan-Teh Chang]

Changed the resolution of this bug to FIXED
because I just checked in the fix for the
poll prototype on the NSPR trunk (NSPR 4.6).
The patch is attached to bug 269591.

So NSPR 4.6 has both a workaround and a fix.