256775 - twisties are invisible in Advanced prefs (options) dialog

Status: VERIFIED FIXED

(Thunderbird :: Preferences, defect)

Description

[sairuh (rarely reading bugmail)]

found using 2004082404-0.8 tbird bits on linux fedora core 1 (also saw on core
2). the twistes are invisible in the Advanced preferences panel.

not a problem on Mac OS X or Windows XP.

to observed, open the Preferences (Options) dialog and go to the Advanced panel.
look at the left side of the righthand panel, and notice that there are no
twisties next to any of the headings:

* Privacy
* General Settings
* Saved Passwords
* Certificates
* Offline and Connection Settings
* Return Receipts
* Software Update

as a workaround, you can mouseover the left edge near each heading: once the
pointer changes into the hand, you can click the invisible twisty to toggle it.

Comment 1

[Scott MacGregor]

I assume you were using the default theme sairuh?

Comment 2

[sairuh (rarely reading bugmail)]

> I assume you were using the default theme sairuh?

yes, I'm using the default theme (Arvid Axelsson's). let me know if you'd like
me to check this with other themes.

Comment 3

[Jeroen Peters]

Attachment: Bring back the twisties in Advanced Preference panel

Stylesheet was referring to png images instead of gif's.

Comment 4

[Scott MacGregor]

Jeroen, does this patch really fix it? Thunderbird uses the qute theme and
shouldn't be building anything from the gnomestripe directory. It seems weird to
me that it would be picking anything up from there....

Comment 5

[Scott MacGregor]

Attachment: possible (untested) fix

Your patch pointed me in the right direction.

It looks like the ifdefs in this make file were causing us to build gnomestripe
on linux even though there is no *stripe theme for thunderbird windows and
linux builds. 

I'm not sure what effect this change may have on linux looking UI within
thunderbird if we stop building this directory.

Care to give this patch a spin?

Comment 6

[Jeroen Peters]

Thanks for looking into this problem Scott.
I will build a new Thunderbird tonight (old machine, it takes some time) and
will report tomorrow (GMT +0200) if this patch works.

Comment 7

[Jeroen Peters]

The patch is working fine. 
I only noticed one change, the selection in the menu's do not follow the setting
of my Gnome theme, but this is a good thing because it shows Gnomestripe is not
included.

Comment 8

[Scott MacGregor]

Attachment: better fix

this fix should allow us to keep the gnomestripe specific style rules for linux
unlike my earlier patch.

Comment 9

[Scott MacGregor]

fixed branch and trunk. Jeroen, can you verify that things look good?

Comment 10

[Jeroen Peters]

I will verify this path as soon as I am home, but his will not be before Monday
or Thuesday.

Comment 11

[Jeroen Peters]

Not sure my comment is still wanted as I see this bug is FIXED, but I had a look
at the last patch. I checked my own build and the offical 0.8 release.

All linux specific style rules are back and I can see twisties in the adv. pref.
window. These twisties are not the same as they were before in Qute, but they
are gnomestripe style. Not sure this is wanted, but at least they are visible again.

Comment 12

[sairuh (rarely reading bugmail)]

looks great with the 0.8 bits (20040913, linux fedora core 2). thanks!