Page Info commandkey is gone on Windows

VERIFIED FIXED in Firefox1.0beta

Status

Firefox Graveyard
Help Documentation
VERIFIED FIXED
13 years ago
2 years ago

People

(Reporter: Steffen Wilberg, Assigned: Steffen Wilberg)

Tracking

1.0 Branch
Firefox1.0beta
x86
Windows XP

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
It used to be Ctrl+J, but that is now Downloads.
(Assignee)

Comment 1

13 years ago
Created attachment 156972 [details] [diff] [review]
Don't show the Page Info row on Windows
(Assignee)

Comment 2

13 years ago
Comment on attachment 156972 [details] [diff] [review]
Don't show the Page Info row on Windows

I see no reason to show this row on Windows without having a key.
Attachment #156972 - Flags: review?(rlk)
(Assignee)

Updated

13 years ago
Blocks: 253104

Comment 3

13 years ago
Comment on attachment 156972 [details] [diff] [review]
Don't show the Page Info row on Windows

>      </tr>
> -    <tr>
> +    <tr class="noWin">
>        <td>Page Info</td>
> -      <td><kbd>Ctrl</kbd>+<kbd class="win">J</kbd><kbd
> -        class="noWin">I</kbd></td>
> +      <td><kbd>Ctrl</kbd>+<kbd>I</kbd></td>
>        <td>&nbsp;</td>
>        <td><kbd>Ctrl</kbd>+<kbd>8</kbd></td>
>      </tr>

If you have noWin as the <tr>, then the hotkey will never be shown when you're
on windows, so the win is useless in the <kbd> tag.
Attachment #156972 - Flags: review?(rlk) → review-
(Assignee)

Comment 4

13 years ago
Comment on attachment 156972 [details] [diff] [review]
Don't show the Page Info row on Windows

> so the win is useless in the <kbd> tag
That's why I removed it :)

-      <td><kbd>Ctrl</kbd>+<kbd class="win">J</kbd><kbd
-	 class="noWin">I</kbd></td>
+      <td><kbd>Ctrl</kbd>+<kbd>I</kbd></td>
Attachment #156972 - Flags: review- → review?
(Assignee)

Comment 5

13 years ago
Comment on attachment 156972 [details] [diff] [review]
Don't show the Page Info row on Windows

See comment 4.
Attachment #156972 - Flags: review? → review?(rlk)

Comment 6

13 years ago
Comment on attachment 156972 [details] [diff] [review]
Don't show the Page Info row on Windows

oh yeah, my bad :). I should get some sleep sometime soon. r=rlk@trfenv.com
Attachment #156972 - Flags: review?(rlk) → review+
(Assignee)

Comment 7

13 years ago
Checked in br & trunk.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox1.0beta

Updated

13 years ago
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.