256845 - Page Info commandkey is gone on Windows

Status: VERIFIED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Steffen Wilberg]

It used to be Ctrl+J, but that is now Downloads.

Comment 1

[Steffen Wilberg]

Attachment: Don't show the Page Info row on Windows

Comment 2

[Steffen Wilberg]

Comment on attachment 156972 [details] [diff] [review]
Don't show the Page Info row on Windows

I see no reason to show this row on Windows without having a key.

Comment 3

[R.J. Keller]

Comment on attachment 156972 [details] [diff] [review]
Don't show the Page Info row on Windows

>      </tr>
> -    <tr>
> +    <tr class="noWin">
>        <td>Page Info</td>
> -      <td><kbd>Ctrl</kbd>+<kbd class="win">J</kbd><kbd
> -        class="noWin">I</kbd></td>
> +      <td><kbd>Ctrl</kbd>+<kbd>I</kbd></td>
>        <td>&nbsp;</td>
>        <td><kbd>Ctrl</kbd>+<kbd>8</kbd></td>
>      </tr>

If you have noWin as the <tr>, then the hotkey will never be shown when you're
on windows, so the win is useless in the <kbd> tag.

Comment 4

[Steffen Wilberg]

Comment on attachment 156972 [details] [diff] [review]
Don't show the Page Info row on Windows

> so the win is useless in the <kbd> tag
That's why I removed it :)

-      <td><kbd>Ctrl</kbd>+<kbd class="win">J</kbd><kbd
-	 class="noWin">I</kbd></td>
+      <td><kbd>Ctrl</kbd>+<kbd>I</kbd></td>

Comment 5

[Steffen Wilberg]

Comment on attachment 156972 [details] [diff] [review]
Don't show the Page Info row on Windows

See comment 4.

Comment 6

[R.J. Keller]

Comment on attachment 156972 [details] [diff] [review]
Don't show the Page Info row on Windows

oh yeah, my bad :). I should get some sleep sometime soon. r=[e-mail]

Comment 7

[Steffen Wilberg]

Checked in br & trunk.