Closed Bug 256886 Opened 18 years ago Closed 18 years ago

leak when opening Themes window

Categories

(Toolkit :: Add-ons Manager, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla1.7.4

People

(Reporter: dbaron, Assigned: dbaron)

Details

(Keywords: fixed-aviary1.0, memory-leak, Whiteboard: [patch])

Attachments

(1 file)

We leak when opening the Themes window in firefox -- the DOMWINDOW doesn't get
destroyed until XPCOM shutdown.
Attached patch patchSplinter Review
This allows |Shutdown| to work correctly by not shadowing a global variable.
Attachment #156990 - Flags: superreview?(brendan)
Attachment #156990 - Flags: review?(bugs)
Whiteboard: [patch]
Comment on attachment 156990 [details] [diff] [review]
patch

sr=brendan@mozilla.org.

/be
Attachment #156990 - Flags: superreview?(brendan) → superreview+
Comment on attachment 156990 [details] [diff] [review]
patch

oops! r+a=ben@mozilla.org for aviary br too
Attachment #156990 - Flags: review?(bugs)
Attachment #156990 - Flags: review+
Attachment #156990 - Flags: approval-aviary+
Fix checked in to AVIARY_1_0_20040515_BRANCH, 2004-08-26 16:52 -0700.
Fix checked in to trunk, 2004-08-26 16:53 -0700.
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed-aviary1.0
Priority: -- → P2
Resolution: --- → FIXED
Target Milestone: --- → Firefox1.0beta
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.