leak when opening Themes window

RESOLVED FIXED in mozilla1.7.4

Status

()

Toolkit
Add-ons Manager
P2
normal
RESOLVED FIXED
14 years ago
10 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

({fixed-aviary1.0, memory-leak})

unspecified
mozilla1.7.4
fixed-aviary1.0, memory-leak
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch])

Attachments

(1 attachment)

1.38 KB, patch
Ben Goodger (use ben at mozilla dot org for email)
: review+
brendan
: superreview+
Ben Goodger (use ben at mozilla dot org for email)
: approval-aviary+
Details | Diff | Splinter Review
We leak when opening the Themes window in firefox -- the DOMWINDOW doesn't get
destroyed until XPCOM shutdown.
Created attachment 156990 [details] [diff] [review]
patch

This allows |Shutdown| to work correctly by not shadowing a global variable.
Attachment #156990 - Flags: superreview?(brendan)
Attachment #156990 - Flags: review?(bugs)
Whiteboard: [patch]
Comment on attachment 156990 [details] [diff] [review]
patch

sr=brendan@mozilla.org.

/be
Attachment #156990 - Flags: superreview?(brendan) → superreview+
Comment on attachment 156990 [details] [diff] [review]
patch

oops! r+a=ben@mozilla.org for aviary br too
Attachment #156990 - Flags: review?(bugs)
Attachment #156990 - Flags: review+
Attachment #156990 - Flags: approval-aviary+
Fix checked in to AVIARY_1_0_20040515_BRANCH, 2004-08-26 16:52 -0700.
Fix checked in to trunk, 2004-08-26 16:53 -0700.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Keywords: fixed-aviary1.0
Priority: -- → P2
Resolution: --- → FIXED
Target Milestone: --- → Firefox1.0beta
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.