as agreed after review and discussion at aviary on http://bugzilla.mozilla.org/show_bug.cgi?id=226791
14 years ago
Whiteboard: ETA: 8/29
Please do not turn off dynamic theme-switching. It WFM, and I abuse the heck out of it. It WFM in all the 2004-08-xx builds, up through 2004-08-27 (today's build). Please keep it. Thank you.
OS: Windows XP → All
Hardware: PC → All
Version: unspecified → 1.0 Branch
What bugs actually remain with it? I'm using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040825 Firefox/0.9.1+ and it WFM just fine.
Two things I would suggest. A) Fixing the themes that have problems the others don't, such as ones with the 'duplicated icons' problem (for example, Firefox Modern). B) If remaining problems cannot be fixed, either invoke a warning box suggesting that they restart their browser (with a checkmark to turn it off), put an option under advanced to enable it, or confirm so we an make an extension.
If you are going to turn off dynamic theme-switching, it would be nice if we could turn it back on if we like.
patch rolled in with 257304
Depends on: 257304
Setting the extensions.dss.enabled pref to true should turn dynamic theme switching back on, but refrain from complaining if it doesn't work properly. It was turned off for a good reason, and will be turned back on when it works properly.
Whiteboard: ETA: 8/29 → ETA: 8/29 - fixed in switch to rdf patch
Fixed on branch, having merging troubles, will land on trunk shortly
confirmed fixed on Windows Firefox Branch 2004-09-10-08-0.9 and Mac Firefox Branch 2004-09-10-07-0.9
This is fixed on trunk (dynamic theme switching is disabled by default).
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.