Closed
Bug 257007
Opened 20 years ago
Closed 20 years ago
Bad link text ("click here") in Firefox help
Categories
(Firefox Graveyard :: Help Documentation, defect)
Firefox Graveyard
Help Documentation
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox1.0
People
(Reporter: me, Assigned: bugzilla)
References
Details
(Keywords: fixed-aviary1.0, late-l10n)
Attachments
(1 file)
1.93 KB,
patch
|
jwalden+fxhelp
:
review+
|
Details | Diff | Splinter Review |
There are a couple of uses of "click here" in Firefox help, the phrase is specifically forbidden in the style guide: http://www.mozilla.org/projects/help-viewer/documentation_language-style.php#links "Link texts should make sense out of context. [...] In particular, the phrase "click here" must never be used." http://lxr.mozilla.org/aviarybranch/source/browser/components/help/locale/en-US/menu_reference.xhtml#268 http://lxr.mozilla.org/aviarybranch/source/browser/components/help/locale/en-US/menu_reference.xhtml#273
Summary: Bad links text (click here) in Firefox help → Bad link text ("click here") in Firefox help
Assignee | ||
Comment 2•20 years ago
|
||
Taking. I think it would be a good idea to change <a href="customization.xhtml#themes[extensions]">Click here</a> for more information on themes[extensions]. to See <a href="customization.xhtml#themes[extensions]">Themes[Extensions]</a> for more information on themes[extensions]. I can make a patch really quick, but I'm waiting for another patch on the same file to get checked in.
Status: NEW → ASSIGNED
Assignee | ||
Updated•20 years ago
|
Assignee: jwalden+fxhelp → nosebleed
Status: ASSIGNED → NEW
Comment 3•20 years ago
|
||
(In reply to comment #2) > See <a href="customization.xhtml#themes[extensions]">Themes[Extensions]</a> > for more information on themes[extensions]. Think about how that would look: See _Themes_ for more information on themes. It's redundant. It's also why I haven't touched this bug yet: I couldn't come up with something that wasn't redundant. Looking at this again jogged my brain some, so I think I have a solution: For more information, see the _Themes_ help topic. If you agree that this works, make a patch with this wording and I'll r+ it.
Assignee | ||
Comment 4•20 years ago
|
||
Jeff, that looks like a satisfactory sentence to me... I hope the attached patch is sufficient enough.
Assignee | ||
Updated•20 years ago
|
Attachment #159243 -
Flags: review?(jwalden+fxhelp)
Comment 5•20 years ago
|
||
Comment on attachment 159243 [details] [diff] [review] First Patch r=jwalden@mit.edu I'll check this in sometime later today.
Attachment #159243 -
Flags: review?(jwalden+fxhelp) → review+
Comment 6•20 years ago
|
||
Well, maybe not "today", per se...fixed branch & trunk.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Updated•20 years ago
|
Status: RESOLVED → VERIFIED
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•