257274 - Minor errors in forieusers.xhtml, using_firebird.xhtml

Status: VERIFIED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Alexander L. Slovesnik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ru-RU; rv:1.7.2) Gecko/20040823 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; ru-RU; rv:1.7.2) Gecko/20040823 Firefox/0.9.1+

In forieusers.xhtml:
http://lxr.mozilla.org/aviarybranch/source/browser/components/help/locale/en-US/forieusers.xhtml#25
"About Your IE Settings"
http://lxr.mozilla.org/aviarybranch/source/browser/components/help/locale/en-US/forieusers.xhtml#73
"About Your IE Favorites and Settings"

In menu_reference.xhtml:
http://lxr.mozilla.org/aviarybranch/source/browser/components/help/locale/en-US/menu_reference.xhtml#312
"<h3 id="about_mozilla_firebird">About &brandFullName;</h3>"
It should be "About &brandshortName;"

In popup.xhtml:
http://lxr.mozilla.org/aviarybranch/source/browser/components/help/locale/en-US/popup.xhtml#43
"icon <img src="chrome://browser/skin/Popup-blocked.png" width="16" height="16"
alt=""/>"
Should it be removed?
In using_firebird.xhtml:
http://lxr.mozilla.org/aviarybranch/source/browser/components/help/locale/en-US/using_firebird.xhtml#97
"<img src="http://mozilla.org/projects/firefox/help/1.0rc1/firefox-toolbar.jpg"
It should be firefox-toolbar.png, cause firefox-toolbar.jpg doesn't exist. 

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Sean Umphlet (nosebleed)]

Attachment: Patch makes changes noted above

Comment 2

[R.J. Keller]

Comment on attachment 157291 [details] [diff] [review]
Patch makes changes noted above

> @@ -40,7 +40,7 @@
>  to prevent popups from appearing in &brandShortName;.</p>
>  
>  <p>When blocking a popup, &brandShortName; displays an
> -icon <img src="chrome://browser/skin/Popup-blocked.png" width="16" height="16" alt=""/> in the
> +icon in the
>  status bar. You can use this icon to add a web site you're viewing to an exceptions
>  list so that the site is allowed to display popups.</p>
>  

hmm. maybe we should restore the site pic instead.

Comment 3

[Sean Umphlet (nosebleed)]

Attachment: Updated patch

That sounds like a good idea... updated the patch accordingly

Comment 4

[R.J. Keller]

Comment on attachment 157368 [details] [diff] [review]
Updated patch

r=[e-mail]

Comment 5

[Jeff Walden [:Waldo]]

This isn't a backend change, so we don't need approval-aviary here as far as I
know (correct me if I'm wrong).

Sometime in the next very few days I should have cvs commit access (just waiting
on some foundation ssh-fu related to my public key), so I'll check it in at that
point.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 157368 [details] [diff] [review]
Updated patch

a=asa for aviary checkin

Comment 7

[Jeff Walden (gone starting June 8)]

Fixed branch and trunk, albeit without the change to menu_reference.xhtml. 
Making that change would mean that Help would say there's a menu item Help>About
Firefox, when the item is really Help>About Mozilla Firefox.  It's sort of an
oddity in that &brandFullName; is used outside of the beginning of a file and in
a place that's not particularly visible, but it's the correct usage.