257275 - Menu doesnt slide to the right on mouse over

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[Dimitris Kotzonis]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3

In the page at http://www.hacshop.gr, the menu doesnt work as in others browsers.
It doesnt slide to right on mouse over.

Reproducible: Always
Steps to Reproduce:
1.Open url
2.Move mouse over the green menu on the left of the page
3.Nothing happens

Actual Results:  
Nothing...

Expected Results:  
Expand the menu to the right.

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

This is invalid JavaScript.

The javascript does:
eval(stuff).foo.bar = someValue

Try doing:
document.getElementById(eval(Stuff)).foo.bar = someValue

I'm not sure if that's the right way to do it, but what's currently written is
wrong.

Comment 2

[Brendan Eich [:brendan]]

The page uses eval gratuitously, where it could use computed property name
indexing.  Instead of:

eval("parent.frames['"+t[1]+"'].document.getElementById('"+t[0]+"')")

use

parent.frames[t[1]].document.getElementById(t[0])

BTW, the other eval computes the name of a global variable, but the standard for
DOM level 0 we follow, the one based on the first implementation of it, does not
make <div id="layer00">, e.g., name a global variable.  However, for quirks
documents, we've just added support for this IE DOM quirk.

This bug was mis-filed in the JavaScript Engine component. Reporter, if it were
not INVALID, it would better go in teh DOM Level 0 component.

/be