Closed
Bug 257338
Opened 20 years ago
Closed 20 years ago
"Delete Host" and "Delete Domain" features of the History Window do not work
Categories
(Core Graveyard :: History: Global, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Stefan.Borggraefe, Assigned: Stefan.Borggraefe)
Details
(Keywords: fixed1.7.5, regression)
Attachments
(1 file)
1.52 KB,
patch
|
benjamin
:
review+
neil
:
superreview+
asa
:
approval1.7.5+
|
Details | Diff | Splinter Review |
Instead both selecting them outputs the following JavaScript error: Error: [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]" nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)" location: "JS frame :: chrome://communicator/content/history/history.js :: anonymous :: line 229" data: no] Source File: chrome://communicator/content/history/history.js Line: 229 Tested with a three day old Linux trunk build.
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Comment 2•20 years ago
|
||
Comment on attachment 157336 [details] [diff] [review] Patch Neil: Don't hesitate to also sr this patch in case you think it is trivial enough. ;-) Thanks! :-)
Attachment #157336 -
Flags: review?(neil.parkwaycc.co.uk)
Comment 3•20 years ago
|
||
Comment on attachment 157336 [details] [diff] [review] Patch sr=me assuming bsmedberg confirms that this is the correct solution.
Attachment #157336 -
Flags: superreview+
Attachment #157336 -
Flags: review?(neil.parkwaycc.co.uk)
Attachment #157336 -
Flags: review?(bsmedberg)
Updated•20 years ago
|
Attachment #157336 -
Flags: review?(bsmedberg) → review+
Assignee | ||
Comment 4•20 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•20 years ago
|
||
Comment on attachment 157336 [details] [diff] [review] Patch Asking for approval1.7.x. Low-risk fix for a feature of the History window.
Attachment #157336 -
Flags: approval1.7.x?
Comment 6•20 years ago
|
||
Comment on attachment 157336 [details] [diff] [review] Patch a=asa for 1.7.x checkin.
Attachment #157336 -
Flags: approval1.7.x? → approval1.7.x+
Assignee | ||
Updated•20 years ago
|
Keywords: fixed1.7.x
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•