257363 - you have to triple-click too fast (twice as fast as you double click)

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Peter]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a3) Gecko/20040817
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a3) Gecko/20040817

I have my double click speed fast on my computer, and Mozilla doesn't give me
long enough to triple click. I think it should give me 2x as much time as it
gives for a double click.

on my computer, if i click twice within 0.4 seconds, it selects the whole word.
if i click 3 times within 0.4 seconds it selects the line. i think i should be
able to click 3 times within 0.8 seconds for a triple click.



Reproducible: Always
Steps to Reproduce:
1. test to see how long you can spend doing a double click
2. click 3 times in the same time you found was required for a double click (no
more, no less)
3.

Actual Results:  
mozilla treats it as a double click followed by a single click. selects 1 word
and then unselects it, placing the cursor wherever you clicked.

Expected Results:  
mozilla should treat it like a triple click, since it is one.

IE, word, eDonkey, windows2000 help, etc. all treat it like a triple click. they
all use your mouse settings, so you get consistently exactly twice as long as it
takes for the double click.

My double click speed is 2 notches less than the maximum in control panel.


i don't think this is a duplicate of bug 194710, because bug 194710 deals with
triple clicking working sometimes but not others, although 1 commenter of that
bug seems to have a similar problem.

Additional Comment #7 From norm megill:
"When I set the
mouse speed fast (which I want to do for other Windows apps) I can't
get the triple-click to work."

Comment 1

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 2

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Does this affect Firefox too?

Comment 3

[Andrew Schultz]

CTho said he could reproduce this bug.

I half-suspect Widget:Win32, but off to selection for now.

Comment 4

[Andrew Schultz]

I half-suspect Widget:Win32... because this worksforme on linux SeaMonkey, 1.0
branch.

I need to click ~1 second between clicks to trigger double-click and if I click
three times with ~1 second between them, it triggers triple-click.

Comment 5

[Uri Bernstein]

*** Bug 194710 has been marked as a duplicate of this bug. ***

Comment 7

[Axel Sander]

Had the same problem. Uninstalled the Alps Touchpad driver. Now it works fine.

Comment 8

[Kestrel]

Triple-clicking is frustrating with Firefox. IE11, Chrome and Opera 12 all extend the time-window for triple-clicking so you can use the same click rate as a double-click. But Firefox seems to use a fixed time-window so you need to increase your click rate to get the three clicks in fast enough. Since the double-click rate can already be quite high this pushes it even higher to a point that most users would be uncomfortable with.

This behavior is unusual, unintuitive and frustrating.

Comment 9

[Kestrel]

Attachment: bug257363.patch - easier triple-click

Observing nsWindow::DispatchMouseEvent:

> NS_MOUSE_BUTTON_DOWN
> sLastClickCount 1
> sLastMouseDownTime 13921328
> NS_MOUSE_BUTTON_UP
> NS_MOUSE_DOUBLECLICK
> sLastClickCount 2
> sLastMouseDownTime 13921328
> NS_MOUSE_BUTTON_UP
> NS_MOUSE_BUTTON_DOWN
> sLastClickCount 3
> sLastMouseDownTime 13921625
> NS_MOUSE_BUTTON_UP

Clearly the second click is not updating sLastMouseDownTime which is resulting in all three clicks needing to be done within one DoubleClickTime instead of two. This is due to the second click using NS_MOUSE_DOUBLECLICK instead of NS_MOUSE_BUTTON_DOWN. The obvious solution is to update sLastMouseDownTime in NS_MOUSE_DOUBLECLICK.

With this patch triple-clicking is much easier and more forgiving.

Comment 10

[Kestrel]

Neil, can you assign this bug to me so I can add the checkin-needed keyword?

Comment 11

[Carsten Book [:Tomcat]]

can we get a try run link here? thanks!

Comment 12

[Kestrel]

I don't have try server access (a 'try-needed' keyword would be useful).

Comment 13

[Carsten Book [:Tomcat]]

(In reply to Kestrel from comment #12)
> I don't have try server access (a 'try-needed' keyword would be useful).

Neil could you do that, thanks!

Comment 14

[Neil Deakin]

Here it is:

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=4d16c0f7e09b

Don't see any issues related to this change.

Comment 15

[Kestrel]

Thanks Neil.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e4aed7beca31

Thanks for the patch! One request, for future patches, please try to use a commit message that explains what the patch is doing instead of restating the problem it's fixing. Thanks!
https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Checkin_comment

Comment 17

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/mozilla-central/rev/e4aed7beca31