Closed Bug 257456 Opened 20 years ago Closed 20 years ago

Hook up small-icon, icons-only and text-only mode for Sunbird's customizable toolbars feature

Categories

(Calendar :: Sunbird Only, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: sipaq, Assigned: sipaq)

Details

Attachments

(1 file, 2 obsolete files)

Patch coming...
Attached patch patch v1(checked in) (obsolete) — — Splinter Review
Assignee: mostafah → bugzilla
Status: NEW → ASSIGNED
Depends on: 250867
Comment on attachment 157436 [details] [diff] [review]
patch v1(checked in)


Although this bug depends on bug 250867, we won't wait for it to be fixed but
once it is, we can back out these changes and use global css
Attachment #157436 - Attachment description: patch v1 → patch v1(checked in)
Summary: Hook up icons-only and text-only mode for Sunbird's customizable toolbars feature → Hook up small-icon, icons-only and text-only mode for Sunbird's customizable toolbars feature
Attached patch Hook up small icons (obsolete) — — Splinter Review
Attachment #157436 - Attachment is obsolete: true
Attachment #157444 - Flags: first-review?(mvl)
Attached patch Hook up small icons - v2 — — Splinter Review
I found some small mistakes in my patch.
Attachment #157444 - Attachment is obsolete: true
Attachment #157444 - Flags: first-review?(mvl)
Attachment #157470 - Flags: first-review?(mvl)
Please create patches from the mozilla dir, not way deep into the directory
tree. It makes it hard to apply them. (you have to read them to find out where
to manually cd to etc..)
Comment on attachment 157470 [details] [diff] [review]
Hook up small icons - v2

>+toolbar[iconsize="small"] #calendar-new-event-button:hover:active {
>+}
Those empty rules are a kind of useless, but since the large buttons have them
to, let it be. We can remove the rules in a seperate bug.
Attachment #157470 - Flags: first-review?(mvl) → first-review+
Checked in small-icons patch.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
No longer depends on: 250867
Status: RESOLVED → VERIFIED
(In reply to comment #6)

> >+toolbar[iconsize="small"] #calendar-new-event-button:hover:active {
> >+}
> Those empty rules are a kind of useless, but since the large buttons have them
> to, let it be. We can remove the rules in a seperate bug.

I filed bug 319426 about it.
The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!
QA Contact: gurganbl → sunbird
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: