Closed
Bug 257491
Opened 20 years ago
Closed 20 years ago
Resetting Browser and clearing the cache should clear the memory cache as well as the disk cache
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino0.9
People
(Reporter: me, Assigned: me)
Details
Attachments
(2 files)
656 bytes,
patch
|
me
:
review+
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
13.16 KB,
application/octet-stream
|
me
:
review+
mikepinkerton
:
superreview+
|
Details |
Even though both functions claim to clear "disk cache", the user has no control over what is cached in memory and what is cached on disk, and the clear expectation when the cache is explicity cleared as in these functions is that all the cache be cleared. I have verified that when other Mozilla browsers clear the "disk cache" in preferences they actually invoke the evictEntries() function twice. Once with STORE_ON_DISK and once with STORE_IN_MEMORY. Looking at nsCacheService.cpp, it is clear that invoking it twice (once with each of those parameters) has the same effect as invoking it once with the parameter STORE_ANYWHERE. To meet the user expectation of the entire cache being cleared and to be consistent with the other mozilla products, Camino should alter the call to cacheServ->EvictEntries(nsICache::STORE_ON_DISK) for both the reset and pref panel to call cacheServ->EvictEntries(nsICache::STORE_ANYWHERE) instead. I will attach a patch once the patch for Bug 257281 lands.
Comment 1•20 years ago
|
||
Looking at Josh's patch he's already fixed this. The line to clear the cache is + cacheServ->EvictEntries(nsICache::STORE_ANYWHERE); And following through the cache code its easy to see that this clears both the memory and disk caches. Resolving as fixed (patch checked in under bug 257281).
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
This bug is not fixed. Cache clearing in the preferences does not clear cache stored in memory. I only fixed half of this bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
update pref text to reflect what is going on more clearly Section title: Cache Explanatory text: The cache keeps copies of frequently visited web pages on your hard disk and in memory. Cached pages load more quickly than ones fetched from the Internet. Button title: Clear Cache
Attachment #163271 -
Flags: review?(me)
Attachment #163273 -
Flags: review?(me)
Attachment #163271 -
Flags: superreview?(pinkerton)
The nib file I attached was update to 10.2 format, so remember to swap objects.nib and keyedobjects.nib when checking in to cvs...
Assignee | ||
Comment 6•20 years ago
|
||
Comment on attachment 163271 [details] [diff] [review] in Navigation pref pane, clear cache in memory as well as on disk This does the job and looks good. r=me@mollyandgeoff.com
Attachment #163271 -
Flags: review?(me) → review+
Assignee | ||
Comment 7•20 years ago
|
||
Comment on attachment 163273 [details] clear up text in prefs interface This is clearer. r=me@mollyandgeoff.com
Attachment #163273 -
Flags: superreview?(pinkerton)
Attachment #163273 -
Flags: review?(me)
Attachment #163273 -
Flags: review+
Comment 8•20 years ago
|
||
Comment on attachment 163271 [details] [diff] [review] in Navigation pref pane, clear cache in memory as well as on disk sr=pink
Attachment #163271 -
Flags: superreview?(pinkerton) → superreview+
Comment 9•20 years ago
|
||
Comment on attachment 163273 [details]
clear up text in prefs interface
sr=pink
Attachment #163273 -
Flags: superreview?(pinkerton) → superreview+
Comment 10•20 years ago
|
||
landed
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•