257491 - Resetting Browser and clearing the cache should clear the memory cache as well as the disk cache

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Geoff "temporarily off bugmail" Beier]

Even though both functions claim to clear "disk cache", the user has no control
over what is cached in memory and what is cached on disk, and the clear
expectation when the cache is explicity cleared as in these functions is that
all the cache be cleared.

I have verified that when other Mozilla browsers clear the "disk cache" in
preferences they actually invoke the evictEntries() function twice. Once with
STORE_ON_DISK and once with STORE_IN_MEMORY. Looking at nsCacheService.cpp, it
is clear that invoking it twice (once with each of those parameters) has the
same effect as invoking it once with the parameter STORE_ANYWHERE.

To meet the user expectation of the entire cache being cleared and to be
consistent with the other mozilla products, Camino should alter the call to
cacheServ->EvictEntries(nsICache::STORE_ON_DISK) for both the reset and pref
panel to call cacheServ->EvictEntries(nsICache::STORE_ANYWHERE) instead.

I will attach a patch once the patch for Bug 257281 lands.

Comment 1

[Bruce Davidson]

Looking at Josh's patch he's already fixed this. The line to clear the cache is
+      cacheServ->EvictEntries(nsICache::STORE_ANYWHERE);
And following through the cache code its easy to see that this clears both the
memory and disk caches.

Resolving as fixed (patch checked in under bug 257281).

Comment 2

[Josh Aas]

This bug is not fixed. Cache clearing in the preferences does not clear cache
stored in memory. I only fixed half of this bug.

Comment 3

[Josh Aas]

Attachment: in Navigation pref pane, clear cache in memory as well as on disk

Comment 4

[Josh Aas]

Attachment: clear up text in prefs interface

update pref text to reflect what is going on more clearly

Section title: Cache

Explanatory text: The cache keeps copies of frequently visited web pages on
your hard disk and in memory. Cached pages load more quickly than ones fetched
from the Internet.

Button title: Clear Cache

Comment 5

[Josh Aas]

The nib file I attached was update to 10.2 format, so remember to swap
objects.nib and keyedobjects.nib when checking in to cvs...

Comment 6

[Geoff "temporarily off bugmail" Beier]

Comment on attachment 163271 [details] [diff] [review]
in Navigation pref pane, clear cache in memory as well as on disk

This does the job and looks good. r=[e-mail]

Comment 7

[Geoff "temporarily off bugmail" Beier]

Comment on attachment 163273 [details]
clear up text in prefs interface

This is clearer. r=[e-mail]

Comment 8

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 163271 [details] [diff] [review]
in Navigation pref pane, clear cache in memory as well as on disk

sr=pink

Comment 9

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 163273 [details]
clear up text in prefs interface

sr=pink

Comment 10

[Josh Aas]

landed