257671 - Error: "gDownloadView.view has no properties" with empty download manager

Status: RESOLVED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[Florian Quèze [:florian]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a3) Gecko/20040817

bug 147842 and bug 163884 seem to be related (other javascript errors in
"downloadmanager.js")

Reproducible: Always
Steps to Reproduce:
1.Open Mozilla
2.Open "javascript console"
3.Open "download manager" (with a empty list of downloaded files)

Actual Results:  
This javascript error is shown 24 times in javascript console :
Error: gDownloadView.view has no properties
Source File: chrome://communicator/content/downloadmanager/downloadmanager.js
Line: 170

Expected Results:  
No javascript error

This error also occurs 6 time each time the (empty) download manager window get
focus.

Comment 1

[Florian Quèze [:florian]]

Attachment: a simple patch

This patch should fix the bug.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Neil, could you check this patch out and drive it in as needed?

Comment 3

[[e-mail]]

Jan, is it reasonable for the view to be null here?

Comment 4

[Jan Varga [:janv]]

I suspect there's no box object yet, so nsTreeBodyFrame::EnsureView() silently
fails to get/create a tree view or there's not body frame even.
This patch looks good to me, there are other similar checks in the download manager.

Comment 5

[[e-mail]]

Fix checked in.