257739 - [ATK] Can't read the title name of windows/dialogs

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Louie Zhao]

The top-level window of mozilla has no accessible name, which prevents
gnopernicus to read the name of window/dialog. This is very important for blind
user to switch between different window/dialog.

Comment 1

[Louie Zhao]

Attachment: patch v1

In order to support getting window name, the patch adds "GetTitle" in
nsIWidget. nsWindow.cpp on different platforms should "implement" this
interface. This patch only does it for gtk2 and returns
NS_ERROR_NOT_IMPLEMENTED on other platforms.

Comment 2

[timeless]

Comment on attachment 157691 [details] [diff] [review]
patch v1

>+  NS_IMETHOD GetTitle(PRUnichar** aTitle);
>   NS_IMETHOD SetTitle(const nsAString& aTitle);

would you please think about what you're doing? ask yourself "why am I making
the getters and setters handle different types?"

and please cc the platform owners, especially tier-1, but be nice and cc tier-3
too.

Comment 3

[Aaron Leventhal]

> would you please think about what you're doing? ask yourself "why am I making
> the getters and setters handle different types?"

Timeless, please learn some social skills. That was quite rude and unnecessary.

Just stick to the facts in a nice way.

Comment 4

[Philip K. Warren]

Attachment: Patch v2

- Instead of pushing GetTitle all the way down to nsIWidget, save the title in
nsXULWindow and return it there. This saves us from having to implement this
method for all of the widget platforms.

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 170938 [details] [diff] [review]
Patch v2

sr=jst

Comment 6

[Louie Zhao]

Patch checked in.

Comment 7

[[e-mail]]

Why couldn't you use the title from the XUL document?

Comment 8

[Aaron Leventhal]

Neil, which method would work better for the embedded Gecko HTML control scenario?

Comment 9

[[e-mail]]

Well, my wild guess would be that embedding wouldn't use nsXULWindow...

Comment 10

[Aaron Leventhal]

Louie, does this work for embedded Gecko windows where the chrome is GTK, such
as in Galeon? Apparently not, as Neil points out that nsIBaseWindow is
implemented by nsXULWindow. Do we need to reopen?

Neil, I don't think your suggestion of using nsXULDocument will help with that
scenario.

Comment 11

[[e-mail]]

Sorry, I didn't mean it as nsXULDocument but nsIDOMNSDocument or nsIDocument.

Comment 12

[Louie Zhao]

I am investigating this and try to use nsIDOMNSDocument instead of nsXULWindow
if embedded Gecko can't work with it. I will reopen (or file a new bug) to fix it.