257751 - "trailing \ in regular expression" JavaScript error is missing line number

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Henrik Gemal]

I just got this JS error:

Error: trailing \ in regular expression

but I'm missing a linenumber and filename

Comment 1

[Henrik Gemal]

this time I think it's in the JS engine:

http://lxr.mozilla.org/mozilla/source/js/src/js.msg#138
http://lxr.mozilla.org/mozilla/source/js/src/jsregexp.c#1002

Comment 2

[Brendan Eich [:brendan]]

Please attach a testcase.  The lxr links you show do not indicate a lack of line
number or filename -- on the contrary, passing state->tokenStream should help
js_ReportCompileErrorNumber cite the filename and line number.  If that token
stream pointer is null, however, then you won't get a file or line.  So, what is
the testcase?  Is it a regexp literal, or a new RegExp("...\") call?

/be

Comment 3

[Erik Fabert]

Attachment: Testcase for Bug 257751

Just the RegExp() call is affected, literals work.

Comment 4

[Bob Clary [:bc] (inactive)]

js/tests/js1_5/Exceptions/regress-257751.js checked in.

Comment 5

[Erik Fabert]

*** Bug 290983 has been marked as a duplicate of this bug. ***

Comment 6

[James Ross]

Attachment: Add code to get a location from the stack frames

This extra code is invoked only when the token stream or code generator are
missing/not specified. This happens (per the comments in the function) when
called from new RegExp(). The extra code uses the context, which is always
bassed in (AFAIK), to determin the location of the error. This fixes the
testcase both in this bug and the duplicate so they show the filename and line
number (but no source line).

Comment 7

[Brendan Eich [:brendan]]

Comment on attachment 181163 [details] [diff] [review]
Add code to get a location from the stack frames

Great, thanks for the patch!  r/a=me for 1.8b2.

/be

Comment 8

[Brendan Eich [:brendan]]

Fixed.

/be

Comment 9

[Bob Clary [:bc] (inactive)]

verified fixed.