Closed Bug 257761 Opened 20 years ago Closed 19 years ago

Empty value gets added to form history when pressing enter in empty search field

Categories

(Firefox :: Search, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: martijn.martijn, Assigned: bryner)

References

Details

Attachments

(1 file)

When submitting the search field in the toolbar with an empty value, that empty
value gets stored in the form history.
This doesn't happen in normal input fields in websites and IE isn't doing this
either, so this is a bug.
Attached patch patchSplinter Review
This fixes that issue, but I've also added an extra check in it for values with
one single space. I don't think they should be added to the form history
either. 
IE doesn't add any strings to the autocomplete popup which only consists of
spaces.

I think this should also apply to input fields in websites (input values which
only consists of spaces should not be stored).
I think the fix should be somewhere here:
http://lxr.mozilla.org/seamonkey/source/toolkit/components/satchel/src/nsFormHistory.cpp#382
Attachment #157707 - Flags: review?(p_ch)
Summary: Empty value gets added to form history when pressing enter in empty search field → Empty value gets added to form history when pressing enter in empty search field
*** Bug 258926 has been marked as a duplicate of this bug. ***
Flags: blocking-aviary1.0?
Assignee: p_ch → bryner
Flags: blocking-aviary1.0? → blocking-aviary1.0-
Can somebody check if this still happens in the trunk?
Attachment #157707 - Flags: review?(p_ch)
Yes, seems already to be fixed somehow in current trunk builds.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: