Closed
Bug 257761
Opened 20 years ago
Closed 19 years ago
Empty value gets added to form history when pressing enter in empty search field
Categories
(Firefox :: Search, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: martijn.martijn, Assigned: bryner)
References
Details
Attachments
(1 file)
1.27 KB,
patch
|
Details | Diff | Splinter Review |
When submitting the search field in the toolbar with an empty value, that empty value gets stored in the form history. This doesn't happen in normal input fields in websites and IE isn't doing this either, so this is a bug.
Reporter | ||
Comment 1•20 years ago
|
||
This fixes that issue, but I've also added an extra check in it for values with one single space. I don't think they should be added to the form history either. IE doesn't add any strings to the autocomplete popup which only consists of spaces. I think this should also apply to input fields in websites (input values which only consists of spaces should not be stored). I think the fix should be somewhere here: http://lxr.mozilla.org/seamonkey/source/toolkit/components/satchel/src/nsFormHistory.cpp#382
Reporter | ||
Updated•20 years ago
|
Attachment #157707 -
Flags: review?(p_ch)
Updated•20 years ago
|
Summary: Empty value gets added to form history when pressing enter in empty search field → Empty value gets added to form history when pressing enter in empty search field
*** Bug 258926 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Flags: blocking-aviary1.0?
Updated•20 years ago
|
Assignee: p_ch → bryner
Flags: blocking-aviary1.0? → blocking-aviary1.0-
Comment 3•20 years ago
|
||
Can somebody check if this still happens in the trunk?
Reporter | ||
Updated•19 years ago
|
Attachment #157707 -
Flags: review?(p_ch)
Reporter | ||
Comment 4•19 years ago
|
||
Yes, seems already to be fixed somehow in current trunk builds.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•