257761 - Empty value gets added to form history when pressing enter in empty search field

Status: RESOLVED WORKSFORME

(Firefox :: Search, defect)

Description

[Martijn Wargers (dead)]

When submitting the search field in the toolbar with an empty value, that empty
value gets stored in the form history.
This doesn't happen in normal input fields in websites and IE isn't doing this
either, so this is a bug.

Comment 1

[Martijn Wargers (dead)]

Attachment: patch

This fixes that issue, but I've also added an extra check in it for values with
one single space. I don't think they should be added to the form history
either. 
IE doesn't add any strings to the autocomplete popup which only consists of
spaces.

I think this should also apply to input fields in websites (input values which
only consists of spaces should not be stored).
I think the fix should be somewhere here:
http://lxr.mozilla.org/seamonkey/source/toolkit/components/satchel/src/nsFormHistory.cpp#382

Comment 2

[PikeUK]

*** Bug 258926 has been marked as a duplicate of this bug. ***

Comment 3

[Hussam Al-Tayeb]

Can somebody check if this still happens in the trunk?

Comment 4

[Martijn Wargers (dead)]

Yes, seems already to be fixed somehow in current trunk builds.