Closed Bug 257859 Opened 16 years ago Closed 16 years ago
SS] Re-insert Alternate Stylesheet UI
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040825 Firefox/0.9.1+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040825 Firefox/0.9.1+ From Bug 253722 Comment #1: > see also bug 216537, bug 253332, bug 216424, bug 224250, bug 220649, > bug 83663, > and bug 220975. Only enhancements to the Alternate Stylesheet functionality and UI remain now, any chance we can have it back by default in Firefox? I know Blake's post is for the purpose of debating, but I figure it needs a bug and votes to make any difference now (since the post is rapidly degenerating). Please don't wontfix this unless you intend to permanently remove the AltSS functionality and/or UI. Reproducible: Always Steps to Reproduce:
Requesting to block 1.0 final, changing version to 1.0 Branch, CC'ing fantasai.
Version: unspecified → 1.0 Branch
This patch would fix this bug by removing the #ifdef checks from browser.js, browser.xul and browser-menubar.inc
Comment on attachment 157846 [details] [diff] [review] Patch to remove #ifdef SHOW_ALT_SS_UI Requesting review, not sure if SR is needed. Please change the SR flag if necessary, Blake.
Blake's on vacation
Comment on attachment 157846 [details] [diff] [review] Patch to remove #ifdef SHOW_ALT_SS_UI Reassigning review and super-review flags to Dbaron and Ben, who were responsible for reviewing other related AltSS patches.
Comment on attachment 157846 [details] [diff] [review] Patch to remove #ifdef SHOW_ALT_SS_UI Clearing review request to me since this is a policy decision rather than a code decision.
...and I'm not the one in charge of the policy in question.
Whiteboard: [have patch]
"Please don't wontfix this unless you intend to permanently remove the AltSS functionality and/or UI." The decision was made to pull this feature from the Firefox 1.0 branch. The functionality and/or UI will remain on the trunk, though I expect the UI to change before the next major Firefox release.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → WONTFIX
We're going to revisit this today, based on fantasai et al.'s progress on the bugs that caused altSS to be removed. /be
Reopening. Setting nomination flag for PR since we'll want to get this in before PR if we add it back.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
ok, we agreed to take this for PR. dbaron will check in.
Flags: blocking-aviary1.0PR? → blocking-aviary1.0PR+
fixed, after discussion at aviary meeting and approval of brendan, ben, etc.
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
*** Bug 263153 has been marked as a duplicate of this bug. ***
it's been removed again!
(In reply to comment #14) > it's been removed again! It's now in View->Page Style.
(In reply to comment #15) > > it's been removed again! > > It's now in View->Page Style. In particular, see bug 262065. It sounds like they decided to make this less visible until style selections can be made "sticky", which I can't blame them for: the behavior isn't intuitive as it stands, and could frustrate new users.
Bug 262065 >>Last modified: 2004-10-19 19:38 PDT (and that wasnt even the patch being checked in it was a comment later on) This bug, c#15 >>From Asaf Romano 2004-10-28 04:31 PDT [reply] ------- Final answer, yes it has been hidden from the somewhat confusing and frustrating statusbar UI, yes it has a reason, no it will not be fixed/changed for 1.0, yes it will be back in future release, no we do not know which release yet.
why not add a check box in Tools, "Options..." for changing this? e.g. "display alternate stylesheet UI in taskbar"
Now this has to be re-enabled since it was disabled by the aviary landing on the branch. It is one the todo list in the "branch landing wiki" http://wiki.mozilla.org/index.php/Firefox:Branch_Landing
(In reply to comment #15) > (In reply to comment #14) > > it's been removed again! > > It's now in View->Page Style. Excuse me, I'm trying to track the history of this feature, do you know the bug num for the move to View->Page Style?
You need to log in before you can comment on or make changes to this bug.