incompatible disabled extensions can be reenabled

RESOLVED FIXED

Status

()

Toolkit
Add-ons Manager
--
major
RESOLVED FIXED
14 years ago
10 years ago

People

(Reporter: asa, Assigned: Ben Goodger (use ben at mozilla dot org for email))

Tracking

({fixed-aviary1.0})

unspecified
fixed-aviary1.0
Points:
---
Bug Flags:
blocking-aviary1.0PR +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

14 years ago
If the app disables extensions as being incompatible after an app upgrade, they
can be re-enabled without warning in the EM. We should prevent this or give a
very clear warning that doing so is ill advised.
(Reporter)

Comment 1

14 years ago
If we're going to need new strings, we'll want to get this ASAP. Setting to
blocking to get on Ben's radar. 
Flags: blocking-aviary1.0PR+

Comment 2

14 years ago
I agree that there should be a warning. But I disagree that it should be
disallowed. After changing to the Sept 3rd nightly all but 2 of my extensions
were disabled. After manually enabling the other 8 or so, all worked flawlessly. 

Comment 3

14 years ago
YES for warning. NO for disabling the re-enabling.

Comment 4

14 years ago
Seconded. Maybe a message like this might do the trick:

"There is a good chance that this extension was disabled automatically because
of compatibility reasons. Re-enabling the extension can cause problems or might
not work at all, because the extension was NOT tested with this version of
Firefox. Are you sure that you want to try to re-enable the extension anyway?
[No] [Yes]" 

Or something like that.
Created attachment 157976 [details] [diff] [review]
patch

Prevent extensions disabled because of incompatibilities from being re-enabled,
and show some visual feedback in the EM.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

14 years ago
I've verified this in the windows branch build from 09/06
Keywords: fixed-aviary1.0
Can you explain the rationale behind the choice to completely disallow
re-enabling "incompatible" extensions? Why would a simple warning, perhaps
mentioning how to start Firefox in Safe Mode, be insufficent?
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.