If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

nsValueArray needs a ReplaceValueAt()

RESOLVED FIXED in Future

Status

SeaMonkey
General
RESOLVED FIXED
13 years ago
11 years ago

People

(Reporter: Chris Thomas (CTho) [formerly cst@andrew.cmu.edu cst@yecc.com], Assigned: Chris Thomas (CTho) [formerly cst@andrew.cmu.edu cst@yecc.com])

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

There is no clean way to replace a value right now.
Blocks: 250811
Summary: nsValueArray a ReplaceValueAt() → nsValueArray needs a ReplaceValueAt()
Created attachment 157919 [details] [diff] [review]
Patch v1
Attachment #157919 - Flags: superreview?(dougt)
Attachment #157919 - Flags: review?(darin)
Whiteboard: r?
Status: NEW → ASSIGNED
+        NS_ASSERTION(0, "surely you've been warned prior to this!");

make that NS_ERROR
Created attachment 157940 [details] [diff] [review]
Patch v2
Attachment #157919 - Attachment is obsolete: true
Attachment #157919 - Flags: superreview?(dougt)
Attachment #157919 - Flags: review?(darin)
Attachment #157940 - Flags: superreview?(dougt)
Attachment #157940 - Flags: review?(darin)
Created attachment 157941 [details] [diff] [review]
Patch v3

<biesi> CTho, + 		   NS_ERROR(0, "surely you've been warned prior
to this!");
<biesi> CTho, that's the wrong syntax :)
Attachment #157940 - Attachment is obsolete: true
Attachment #157940 - Flags: superreview?(dougt)
Attachment #157940 - Flags: review?(darin)
Attachment #157941 - Flags: superreview?(dougt)
Attachment #157941 - Flags: review?(bsmedberg)

Comment 5

13 years ago
Comment on attachment 157941 [details] [diff] [review]
Patch v3

Wow, this is ugly. It appears to work.
Attachment #157941 - Flags: review?(bsmedberg) → review+
Product: Browser → Seamonkey
Status: ASSIGNED → NEW
Assignee: cst → general
Target Milestone: --- → Future

Comment 6

13 years ago
Comment on attachment 157941 [details] [diff] [review]
Patch v3

alec, got time to sr this?
Attachment #157941 - Flags: superreview?(dougt) → superreview?(alecf)

Comment 7

13 years ago
Comment on attachment 157941 [details] [diff] [review]
Patch v3

sr=alecf
Attachment #157941 - Flags: superreview?(alecf) → superreview+
Assignee: general → cst
Whiteboard: r?
Sorry, got tired of waiting for SR and took the bug off my to-do list...when I eventually got SR, I forgot it was my bug.  Patch checked in.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.