258092 - nsDeviceContextSpecB.h includes itself!?

Status: RESOLVED FIXED

(Core Graveyard :: GFX: BeOS, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

44 #include "nsDeviceContextSpecB.h"

Comment 1

[Yuliy Pisetsky]

Well the code is perfectly harmless due to the include guard, but it's kind of
silly to include it. It was commented out in the original version of the file,
but then uncommented in 1.3: <a
href="http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/gfx/src/beos&command=DIFF_FRAMESET&file=nsDeviceContextSpecB.h&rev2=1.3&rev1=1.1">
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/gfx/src/beos&command=DIFF_FRAMESET&file=nsDeviceContextSpecB.h&rev2=1.3&rev1=1.1</a>.
It looks safe enough to remove, as it really does nothing

Comment 2

[tqh]

I can't see any reason why it's needed. If anyone is planning to fix it's in
AVIARY line 45 as well.

CC'ing Sergei.

Comment 3

[tqh]

Attachment: Removed line

This one compiles, so Sergei I think your review will be easy. Let's close this
one.

Comment 4

[Sergei Dolgov]

Comment on attachment 174138 [details] [diff] [review]
Removed line

r=sergei_d

Comment 5

[tqh]

Sergei, could you check in this one as well?

Comment 6

[Sergei Dolgov]

Did it now, but something weird happened.
i don't see actual changes between version 1.18 and 1.17.
Maybe it was already done silently by someone else?
Can you look at your current sources and then checkout that file from CVS?

Comment 7

[tqh]

Seems ok in CVS now.

Comment 8

[Sergei Dolgov]

ok, so fixed