Last Comment Bug 258092 - nsDeviceContextSpecB.h includes itself!?
: nsDeviceContextSpecB.h includes itself!?
Status: RESOLVED FIXED
:
Product: Core Graveyard
Classification: Graveyard
Component: GFX: BeOS (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: ---
Assigned To: tqh
: QA timeless
Mentors:
http://lxr.mozilla.org/seamonkey/sour...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-09-05 07:41 PDT by Christian :Biesinger (don't email me, ping me on IRC)
Modified: 2009-01-22 10:17 PST (History)
3 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Removed line (539 bytes, patch)
2005-02-12 04:50 PST, tqh
sergei_d: review+
Details | Diff | Review

Description Christian :Biesinger (don't email me, ping me on IRC) 2004-09-05 07:41:31 PDT
44 #include "nsDeviceContextSpecB.h"
Comment 1 Yuliy Pisetsky 2004-09-05 09:07:50 PDT
Well the code is perfectly harmless due to the include guard, but it's kind of
silly to include it. It was commented out in the original version of the file,
but then uncommented in 1.3: <a
href="http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/gfx/src/beos&command=DIFF_FRAMESET&file=nsDeviceContextSpecB.h&rev2=1.3&rev1=1.1">
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/gfx/src/beos&command=DIFF_FRAMESET&file=nsDeviceContextSpecB.h&rev2=1.3&rev1=1.1</a>.
It looks safe enough to remove, as it really does nothing
Comment 2 tqh 2004-09-05 10:13:28 PDT
I can't see any reason why it's needed. If anyone is planning to fix it's in
AVIARY line 45 as well.

CC'ing Sergei.
Comment 3 tqh 2005-02-12 04:50:17 PST
Created attachment 174138 [details] [diff] [review]
Removed line

This one compiles, so Sergei I think your review will be easy. Let's close this
one.
Comment 4 Sergei Dolgov 2005-02-12 05:10:22 PST
Comment on attachment 174138 [details] [diff] [review]
Removed line

r=sergei_d
Comment 5 tqh 2005-02-20 13:20:38 PST
Sergei, could you check in this one as well?
Comment 6 Sergei Dolgov 2005-02-20 13:43:47 PST
Did it now, but something weird happened.
i don't see actual changes between version 1.18 and 1.17.
Maybe it was already done silently by someone else?
Can you look at your current sources and then checkout that file from CVS?
Comment 7 tqh 2005-02-20 23:35:53 PST
Seems ok in CVS now.
Comment 8 Sergei Dolgov 2005-02-21 03:29:36 PST
ok, so fixed

Note You need to log in before you can comment on or make changes to this bug.


Privacy Policy