Closed
Bug 258092
Opened 16 years ago
Closed 15 years ago
nsDeviceContextSpecB.h includes itself!?
Categories
(Core Graveyard :: GFX: BeOS, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Biesinger, Assigned: thesuckiestemail)
References
()
Details
Attachments
(1 file)
|
539 bytes,
patch
|
sergei_d
:
review+
|
Details | Diff | Splinter Review |
44 #include "nsDeviceContextSpecB.h"
Comment 1•16 years ago
|
||
Well the code is perfectly harmless due to the include guard, but it's kind of silly to include it. It was commented out in the original version of the file, but then uncommented in 1.3: <a href="http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/gfx/src/beos&command=DIFF_FRAMESET&file=nsDeviceContextSpecB.h&rev2=1.3&rev1=1.1"> http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/gfx/src/beos&command=DIFF_FRAMESET&file=nsDeviceContextSpecB.h&rev2=1.3&rev1=1.1</a>. It looks safe enough to remove, as it really does nothing
I can't see any reason why it's needed. If anyone is planning to fix it's in AVIARY line 45 as well. CC'ing Sergei.
This one compiles, so Sergei I think your review will be easy. Let's close this one.
Assignee: beos → thesuckiestemail
Status: NEW → ASSIGNED
Attachment #174138 -
Flags: review?(sergei_d)
Comment 4•15 years ago
|
||
Comment on attachment 174138 [details] [diff] [review] Removed line r=sergei_d
Attachment #174138 -
Flags: review?(sergei_d) → review+
Comment 6•15 years ago
|
||
Did it now, but something weird happened. i don't see actual changes between version 1.18 and 1.17. Maybe it was already done silently by someone else? Can you look at your current sources and then checkout that file from CVS?
Seems ok in CVS now.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 8•15 years ago
|
||
ok, so fixed
Updated•11 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•