Closed
Bug 258126
Opened 21 years ago
Closed 21 years ago
text-decoration drawn wrong on broken inline with side padding
Categories
(Core :: Layout: Block and Inline, defect, P2)
Core
Layout: Block and Inline
Tracking
()
RESOLVED
FIXED
mozilla1.8alpha4
People
(Reporter: dbaron, Assigned: dbaron)
References
()
Details
(Whiteboard: [patch])
Attachments
(2 files)
|
509 bytes,
text/html; charset=UTF-8
|
Details | |
|
1.92 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
We don't call GetSkipSides, so 'text-decoration's are drawn incorrectly when an
inline with side padding is split over multiple lines.
Steps to reproduce:
* load attached testcase
Expected results:
* underline on first line ends even with the text
Actual results:
* underline on first line ends a bit before the end of the text
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Comment 2•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [patch]
Target Milestone: --- → mozilla1.8alpha4
|
|
Assignee | |
Updated•21 years ago
|
Attachment #157972 -
Flags: superreview?(bzbarsky)
Attachment #157972 -
Flags: review?(bzbarsky)
|
||
Comment 3•21 years ago
|
||
Comment on attachment 157972 [details] [diff] [review]
patch
r+sr=bzbarsky, but is there a good reason not to put the nsMarginSides thing in
nsMargin.h?
Also, does this pretty much address bug 238473? The patch there seems to be
fairly similar...
Attachment #157972 -
Flags: superreview?(bzbarsky)
Attachment #157972 -
Flags: superreview+
Attachment #157972 -
Flags: review?(bzbarsky)
Attachment #157972 -
Flags: review+
|
|
Assignee | |
Comment 4•21 years ago
|
||
I'm a little afraid of linking issues if I put this in nsMargin.h.
|
|
Assignee | |
Comment 5•21 years ago
|
||
Fix checked in to trunk, 2004-10-25 16:48 -0700.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•