258126 - text-decoration drawn wrong on broken inline with side padding

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We don't call GetSkipSides, so 'text-decoration's are drawn incorrectly when an
inline with side padding is split over multiple lines.

Steps to reproduce:
 * load attached testcase

Expected results:
 * underline on first line ends even with the text

Actual results:
 * underline on first line ends a bit before the end of the text

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: testcase

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 157972 [details] [diff] [review]
patch

r+sr=bzbarsky, but is there a good reason not to put the nsMarginSides thing in
nsMargin.h?

Also, does this pretty much address bug 238473?  The patch there seems to be
fairly similar...

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm a little afraid of linking issues if I put this in nsMargin.h.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2004-10-25 16:48 -0700.