25819 - nsIMsgMessageService.CopyMessage doesn't call stream listener for news messages

Status: VERIFIED WORKSFORME

(MailNews Core :: Backend, defect, P3)

Description

[cbegle]

M13, Win98.

I would like to be able to select a menu item that calls a script that parses 
the text of a news message.

I have a script allows me to parse the text of a mailbox_message.  However, the 
stream listener's OnDataAvailable never gets called if I try a slightly 
modified script on a news message.  (The only difference is that the 
messageService is an instance of 
"component://netscape/messenger/messageservice;type=news_message"
instead of 
"component://netscape/messenger/messageservice;type=mailbox_message"

I'll attach the whole function.

Any clues?

Comment 1

[cbegle]

Attachment: script that shows my problem

Comment 2

[cbegle]

the way i'm running this script is by overriding one of the event handlers 
called by menu items in the mailnews window's Message menu.

Comment 3

[Scott MacGregor]

re-assigning to me.

Comment 4

[cbegle]

I rebuilt this morning, and my stream listener is now being notified.  
Excellent!

Comment 5

[cbegle]

spoke too soon, i tried it against what was an old build.  arg, too many builds 
on my machine.

Comment 6

[cbegle]

scott, do you think this will happen for beta1?  If not, I am going to have to 
come up with a different solution for dealing with newsgroup feedback.

Comment 7

[leger]

Putting on PDT- radar for beta1.  This is not a stopper for beta.

Comment 8

[Scott MacGregor]

when using news_message, do you get a message service back at all? or does that
throw an exception in JS?

If you do get one back. are you getting a on start request call? Just no on data
available?

Comment 9

[Scott MacGregor]

I did notice one thing...I'm not sure if JS handles this or not...but your
variable for the news uri is defined inside of a block:
if ()
{
var uri = get the uri for the selection in the thread pane
}

then outside of that block you reference the variable uri in order to pass it
into the copy service. Does JS remember the variable outside of the scope it was
defined in?

just curious.

Oh one more question, when you run this test script for news, what does the dump
statement for the news uri look like?

Comment 10

[cbegle]

Hey, Scott.  I updated and will attach the new version of the script.  The only 
real difference is that I moved that uri declaration out of the if block, and 
added some stuff to the dump statements so you know where that output comes 
from.
 
What class has an OnStartRequest method?  I didn't think I needed anything else.
I implemented nsIURLListener (with methods OnStartRunning/OnStopRunning) and an 
nsIStreamListener (OnDataAvailable).  OnDataAvailable never gets called.

I am pretty sure that CopyMessage succeeds; no JavaScript exception is thrown, 
and the nsIURLListener start/stop running methods are called.  Odd: looks like 
the OnStartRunning method is called twice.

Here's the console output.  Note that MsgURLListener's OnStartRunning method is 
called twice, but the MsgStreamListener's OnDataAvailable method is not called 
at all.  I'll attach the script that generated this output.

EventHandler: currentMessage id:     
news_message://news.mozilla.org/netscape.test#3104
MsgURLListener: start running /[e-mail]
EventHandler: CopyMessage completed without error.
EventHandler: done handling
MsgURLListener: start running /[e-mail]
MsgURLListener: stopped running /[e-mail]:2153185328
Document: Done (1.125 secs)

(Note: if i substitute this line of the script:
    var messageService = Components.classes[
        "component://netscape/messenger/messageservice;type=news_message"]
        .getService();

with this:
    var messageService = Components.classes[
        "component://netscape/messenger/messageservice;type=mailbox_message"]
        .getService();

And run the same script on a mailbox message, the script works fine.  Stream 
Listener gets called and I can get the contents of the message.)

Comment 11

[cbegle]

Attachment: test case.

Comment 12

[Scott MacGregor]

Oh okay this might be in. First I have to confess that I have not tried running
your script yet. But this might be the problem....

nsIStreamListener has a method called OnDataAvailable which you added to your
variable. However, it also inherits from nsIStreamObserver which is the class
that has:
OnStartRequest
OnStopRequest

Your variable needs to support these methods too. Maybe the problem is that
because of this, xpconnect isn't properly creating a nsIStreamListener to get
passed around the back end.

I'd suggest giving that a try.

Comment 13

[Christine Begle]

that's it. thanks, mscott!

Comment 14

[Christine Begle]

it works.

Comment 15

[lchiang]

I'll mark as verified then per christine's comment.