258244 - View page info dialog size too small for https site

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Leon Sha]

go to https://sourceforge.net
Press Ctrl+I to view page info,
The default dialog size is too small, contents are clipped.

Comment 1

[Leon Sha]

Attachment: Patch

Comment 2

[Leon Sha]

The reason for this is the string in security page "Connection Encrypted:
High-grade Encryption (%S %S bit)" is too long. You can see it here:
http://lxr.mozilla.org/seamonkey/source/security/manager/pki/resources/locale/en-US/pippki.properties#120

Another way is to modify the style of this lable. Don't set it as "header".

Comment 3

[Daniel Brooks [:db48x]]

Comment on attachment 158097 [details] [diff] [review]
Patch

r=db48x

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 158097 [details] [diff] [review]
Patch

This sorta needs moa by neil anyway, so setting sr to him.

Comment 5

[[e-mail]]

I don't see the problem, is this something to do with large fonts? In which
case, better would be a patch that replace the pixels with styles in ems.

Comment 6

[Leon Sha]

I can see this problem in all unix/linux platform. In fact the reason is all the
head message can not wrap, like "Connection Encrypted:
High-grade Encryption (%S %S bit)". We can modify the default size or change the
style of head message. 

Comment 7

[Daniel Brooks [:db48x]]

It's one of those things that's difficult to fix correctly. Most fixes would
just end up making the dialog larger than the screen in some cases, which I
think is worse.

Comment 8

[Daniel Brooks [:db48x]]

fix checked in

Comment 9

[Daniel Brooks [:db48x]]

oops. It was actually bug 254086 that I checked in last night :P

Comment 10

[Leon Sha]

Attachment: Patch, v2

I let the "security-privacy" message to be wrapable.

Comment 11

[[e-mail]]

Comment on attachment 162167 [details] [diff] [review]
Patch, v2

r+sr=me on PageInfoOverlay.xul but not on pageInfo.dtd which looks like it was
left over from the previous patch.

Comment 12

[Ginn Chen]

Checking in PageInfoOverlay.xul;
/cvsroot/mozilla/security/manager/pki/resources/content/PageInfoOverlay.xul,v 
<--  PageInfoOverlay.xul
new revision: 1.20; previous revision: 1.19
done