258280 - Context Menu (w/ Java Script blocking disabled) does not show correct context menu due to alert() message

Status: RESOLVED EXPIRED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Zook Valem]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.1) Gecko/20040707
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.1) Gecko/20040707

Java Script blocked the context menu from activating due to image copyright
protection.  It prevent me from opening the webpage into a new tab or window,
even though there is no interest(s)/reason(s) for saving the copyright-protected
image at all.  We should not be denied from opening the new tab/window either.

Reproducible: Always
Steps to Reproduce:
1. Move mouse over the image (the bed vibrator image)
2. Right mouse click it (or left mouse click it for left hander)


Actual Results:  
I get the javascript alert message saying "Image Protected" which is then
followed by a different context menu like 1) Save Page As, or 2) View Source, or
3) Refresh/Reload/Back/Forward event but no option to open into new tab/window.

Expected Results:  
Should have allow me to open into new tab/window.

Comment 1

[Zook Valem]

One further info....  I resigned in defeat by copying the URL address, manually
opened into a new tab, paste it into a new tab and click on the image link to
get to a new webpage.  It never occurred to me that there is an anchor link to
the right of hte image due to the "Hover" feature until a few hours later when I
was doing some analyzing on whether to file this bug report or not.  So, there
are a good chance that other would never noticed the comments is actually an
anchor link too.

Comment 2

[Zook Valem]

Javascript codes below for your convience...  I pulled it off of that website...

--snip--
/*
Disable right click script II (on images)
*/

var clickmessage="Image copyrighted."

function disableclick(e) {
if (document.all) {
if (event.button==2||event.button==3) {
if (event.srcElement.tagName=="IMG"){
alert(clickmessage);
return false;
}
}
}
else if (document.layers) {
if (e.which == 3) {
alert(clickmessage);
return false;
}
}
else if (document.getElementById){
if (e.which==3&&e.target.tagName=="IMG"){
alert(clickmessage)
return false
}
}
}

function associateimages(){
for(i=0;i<document.images.length;i++)
document.images[i].onmousedown=disableclick;
}

if (document.all)
document.onmousedown=disableclick
else if (document.getElementById)
document.onmouseup=disableclick
else if (document.layers)
associateimages()
--snip--

Comment 3

[Zook Valem]

Attachment: testcase 1

Comment 4

[Boris Zbarsky [:bzbarsky]]

Note that on Linux the context menu comes up onmousedown, so in fact the code
will not work on Linux...

That said, cancelling any event other than oncontextmenu should really not
prevent the context menu, I think.

Comment 5

[Zook Valem]

Ummm, very interesting observation.  Didn't see this from before  When I clicked
"OK" in the alert box, a lot of features in the context menu doesn't show up. 
But when I pressed the Enter key on the keyboard, a lot of features show up in
the context menu, including the open into new tab/window part.  Now I'm
beginning to understand the problem here.  This is an unique situation.  It look
like I may have filed this bug prematurely because it now look like it's not a
bug after all.   

It's an human factor and interface design issue(s) after all.  The obvious
distraction to all of this is the alert pop-up window which lead to many
mistakes and confusions.  See, when you do the right-mouse click, NOT move the
mouse and press the Enter key on the keyboard then the correct context menu show
up.  But when you right-mouse click it and MOVE hte mouse off of the anchor area
where the image is, it's no longer an anchor link and the context menu changed
to a different context menu.  No wonder why I got distracted by the alert pop-up
box and not know that I'm no longer on the anchor link.  So, I can go ahead and
resolve this bug to WFM but I believe the context menu shouldn't change once the
right-click event is activated, so that's become a different bug.  Well, I'll
let you be the judge of it.  I will accept anything you will do to this bug
report and I ask you to do it wisely, not hastly.  Got it!!!

Comment 6

[Zook Valem]

FYI, you would need to do this for it to work..  Edit --> Preference -->
Advanced --> Scripts & Plug-Ins --> Allow scripts to: --> Unchecked the checkbox
for "Disable or replace the context menu".

Changing summary to better reflect this bug report.  Again, context menu should
show proper menus after the right/left mouse click, even when it get delayed by
the javascript alert message.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Note that this is no different from right mouse down, drag, right mouse up.  Try
doing that and see what context menu you get.

In any case, this is only a problem on Windows, with its onmouseup context menu
silliness.

Comment 8

[Zook Valem]

Very interesting.  I did the right mouse down, drag, right mouse up to outside
of the anchor/image area and saw 2 difference.  1) No pop-up alert message and
2) Got a context menu with (a)Back/Forward/Reload/Stop, (b) Bookmark This Page,
Save Page As.., Send Page.., (c) View Background Image, Select All and (d) View
Page Source, View Page Info, Properties. A new testcase coming up soon....

Comment 9

[Zook Valem]

Attachment: testcase 2

Comment 10

[Zook Valem]

Attachment: testcase 3

Comment 11

[Zook Valem]

"testcase 3" is a simplier testcase to "testcase 1" and it still show this
problem.  But with "testcase 2", it does not show this problem.  The different
between "testcase 2" and "testcase 3" is the javascript's event script. 
"testcase 2" doesn't have this but "testcase 3" does.

Comment 12

[Zook Valem]

Scratch what I said from the last comment.  "testcase 2" show this problem with
the right mouse down, drag and right mouse up.  Sorry for the spam...

Comment 13

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 14

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.