258302 - middle clicking "Open in Tabs" does nothing.

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, enhancement)

Description

[Jeremy M. Dolan]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040902 Firefox/1.0 PR

Middle-clicking (and presumably accel-clicking) bookmarks in the Bookmarks menu
and personal toolbar opens the selected bookmark in a new tab (and presumably a
new window, depending on prefs).

However, middle-clicking the "Open in Tabs" item simply destroys the menu. No
pages are loaded in the current or new tabs. Expected behavior, I think, would
be to create new tabs for the items in the folder and load them all (as opposed
to "overwriting" the current tabs).

Comment 1

[Ryan Polk (Quark)]

JS Console:
Error: aTarget.parentNode has no properties
Source File: chrome://browser/content/bookmarks/bookmarksMenu.js
Line: 373

Comment 2

[Nickolay_Ponomarev]

no js console error for me, Firefox 1.0

Comment 3

[Martijn Wargers (dead)]

I think these are the relevant functions:

See the loadBookmark function
http://lxr.mozilla.org/seamonkey/source/browser/components/bookmarks/content/bookmarksMenu.js#437

openBookmark:
http://lxr.mozilla.org/seamonkey/source/browser/components/bookmarks/content/bookmarks.js#636

Comment 4

[Martijn Wargers (dead)]

Attachment: patch

Like this?
The js error is occuring because in loadBookmarkMiddleClick, the menupopup
closing function is executed before the execution of the loadBookmark function.

This patch fixes that also.

Comment 5

[Thomas Rutter]

This is now also the case in History -> Recently Closed Tabs -> Open in Tabs.

Middle clicking virtually anything within the History or Bookmarks sub-menus will achieve something, but middle-clicking closes the menu without doing anything.

Comment 6

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change

Comment 7

[Phil Ringnalda (:philor)]

*** Bug 361438 has been marked as a duplicate of this bug. ***

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

WFM on current trunk
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20081215 Minefield/3.2a1pre