Closed Bug 258361 Opened 16 years ago Closed 7 years ago

replace XUL_NAMESPACE with XUL_NS

Categories

(SeaMonkey :: General, defect)

x86
Windows XP
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.23

People

(Reporter: timeless, Assigned: philip.chee)

References

()

Details

Attachments

(2 files)

 
Attached patch PatchSplinter Review
Assignee: guifeatures → mcsmurf
Status: NEW → ASSIGNED
i'll no longer work on this
Assignee: mcsmurf → guifeatures
Status: ASSIGNED → NEW
Product: Core → Mozilla Application Suite
Attachment #158186 - Flags: review?(timeless)
Attachment #158186 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #158186 - Flags: review?(timeless)
Attachment #158186 - Flags: review+
Comment on attachment 158186 [details] [diff] [review]
Patch

bookmarks.js already tries to define XUL_NS...
Attachment #158186 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview-
Filter "spam" on "guifeatures-nobody-20080610".
Assignee: guifeatures → nobody
QA Contact: guifeatures
Component: XP Apps: GUI Features → UI Design
Component: UI Design → General
Keywords: helpwanted
[I guess I could have carried forward r=timeless since we now don't require sr for trivial patches].

> bookmarks.js already tries to define XUL_NS...
Not any more.

A quick grep shows we use XUL_NS, XULNS, xulNS, kXULNS ...
Since timeless wants XUL_NS I guess that's the way to go.
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #791655 - Flags: review?(bugzilla)
Attachment #791655 - Flags: review?(bugzilla) → review+
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/192ef9075e29
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.23
You need to log in before you can comment on or make changes to this bug.