258485 - "Refresh Live Bookmark" should be "Reload Live Bookmark"

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Grey Nicholson (they/them)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.3) Gecko/20040908 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.3) Gecko/20040908 Firefox/0.10

Firefox prefers "reload" over "refresh"; the context menu of live bookmark
folders should read "Reload Live Bookmark" instead of "Refresh Live Bookmark".

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Grey Nicholson (they/them)]

Affects l10n; requesting blocking-aviary1.0PR

Comment 2

[Mike Connor [:mconnor]]

wording changes do NOT affect l10n.  Adding strings to be localized does, but
since localizers will translate consistently or not as they see fit, it doens't
matter.

If we change the content of a string, it doesn't affet other language packs.

Comment 3

[u88484]

I'm cofirming this because it makes sense follow through with the wording of the
reload button on the navigational toolbar. Both refresh or reload something so
both should be called the same thing, either 'Reload' or 'refresh' not different
names for each.

Comment 4

[Peter van der Woude [:Peter6]]

->NEW

(or this will rot unco)

Comment 5

[Max Waterman]

I was going to file a bug about this option being missing.

Could you explain where this 'Refresh live bookmark' option is?

Max.

Comment 6

[Grey Nicholson (they/them)]

(In reply to comment #5)
> Could you explain where this 'Refresh live bookmark' option is?
Right-click a live bookmark > Refresh Live Bookmark

Comment 7

[Tim Meader]

Attachment: quick text change of "refresh"

Quick fix. Gonna request review on Firefox channel. If I can't get it in a few
days, I'll make it official.

Comment 8

[Tim Meader]

Comment on attachment 176976 [details] [diff] [review]
quick text change of "refresh"

Please checkin if you find this okay.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Trivial bugs don't block releases, by definition. The blocking flag isn't an
attention flag.

Comment 10

[Tim Meader]

Comment on attachment 176976 [details] [diff] [review]
quick text change of "refresh"

Trying mconnor instead.

Comment 11

[timeless]

Comment on attachment 176976 [details] [diff] [review]
quick text change of "refresh"

mozilla/browser/locales/en-US/chrome/browser/bookmarks/bookmarks.properties    
1.9
mozilla/browser/locales/en-US/chrome/browser/bookmarks/bookmarks.dtd	1.8

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Someone forgot to change the accesskey.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Attachment: Change accesskey

"B" isn't used anywhere else in the menu, and is nice and visible. "R" is
already used for P_r_eferences.

Comment 14

[:Gavin Sharp [email: [e-mail]]]

Attachment: Don't forget the bookmarks manager!

Mano pointed out that I forgot the Bookmark Manager.

Comment 15

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 186659 [details] [diff] [review]
Don't forget the bookmarks manager!

Oh, and I decided to use "L" instead since it can be used in both cases without
conflict.

Comment 16

[Asaf Romano (gone)]

Checking in browser/locales/en-US/chrome/browser/bookmarks/bookmarks.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/bookmarks/bookmarks.dtd,v
 <--  bookmarks.dtd
new revision: 1.9; previous revision: 1.8
done
Checking in browser/locales/en-US/chrome/browser/bookmarks/bookmarks.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/bookmarks/bookmarks.properties,v
 <--  bookmarks.properties
new revision: 1.10; previous revision: 1.9
done
Checking in browser/components/bookmarks/content/bookmarksManager.xul;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarksManager.xul,v 
<--  bookmarksManager.xul
new revision: 1.29; previous revision: 1.28
done

Comment 17

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change