Closed Bug 258628 Opened 20 years ago Closed 20 years ago

dropping folders in bookmark manager item pane should update content view

Categories

(Camino Graveyard :: Bookmarks, defect)

PowerPC
macOS
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
Camino0.9

People

(Reporter: jaas, Assigned: mikepinkerton)

References

Details

(Whiteboard: will need to be landed on trunk and branch)

Attachments

(1 file)

Import Firefox bookmarks. See how they appear in the bottom of the left-hand
bookmark folder list. Select the new imported bookmarks folder. See Firefox
bookmarks on the right. Now drag the Firefox bookmarks folder up and drop it on
your Bookmark Menu folder. The Bookmark Menu folder is selected on the left, but
the view never changes on the right, and it appears that you just overwrote all
of your bookmarks with the imported ones. You didn't really, if you force the
bookmark manager to update its right-hand view, but it was hella scary for a few
seconds.
Target Milestone: --- → Camino0.9
Attached patch a patchSplinter Review
move update selection code into notification method, remove now useless
"shouldSelectRow" delegate method, force a refresh of the outline view on drag
& drops.
Attachment #158553 - Flags: review?(joshmoz)
Attachment #158553 - Flags: review?(qa-mozilla)
Blocks: 261393
Attachment #158553 - Flags: review?(qa-mozilla) → review+
Attachment #158553 - Flags: review?(joshmoz)
Whiteboard: will need to be landed on trunk and branch
Attachment #158553 - Flags: superreview?(pinkerton)
Comment on attachment 158553 [details] [diff] [review]
a patch

sr=pink.

josh, want to land this?
Attachment #158553 - Flags: superreview?(pinkerton) → superreview+
landed on both branch and trunk
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: