Closed
Bug 258650
Opened 20 years ago
Closed 19 years ago
Properly remove extensionHome.png and extensionAbout.png from tree
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jwalden+fxhelp, Assigned: Waldo)
Details
Attachments
(1 file, 1 obsolete file)
14.95 KB,
patch
|
kevin
:
review+
asa
:
approval-aviary1.1a1+
|
Details | Diff | Splinter Review |
The files were cvs remove'd from the tree, but the corresponding entries in jar.mn weren't removed, causing a build error when the files weren't found. The fix is to remove the lines from jar.mn, at which point it's then safe to cvs remove the images (after a suitable time for builds-in-progress to complete). Patch coming up in a jiffy for the proper jar.mn...
Assignee | ||
Comment 1•20 years ago
|
||
This fixes the problem of builds failing. It might also be worth lumping in removing the other reference(s) to the files from source. I see at least one in mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensions.css (via LXR search for file name). That can be another patch for later -- I've gotta go now.
Assignee | ||
Comment 2•20 years ago
|
||
Comment on attachment 158362 [details] [diff] [review] Removes files from jar.mn Vlad, can you review this?
Attachment #158362 -
Flags: review?(vladimir)
Comment on attachment 158362 [details] [diff] [review] Removes files from jar.mn sure, looks fine to me; probably no need for a patch for this stuff though, someone just needs to go and remove it (files and jar.mn bits) if it's not needed any more.
Attachment #158362 -
Flags: review?(vladimir) → review+
Assignee | ||
Comment 4•20 years ago
|
||
Comment on attachment 158362 [details] [diff] [review] Removes files from jar.mn I guess the next step is approval-aviary? here (unless your r+ is good enough, vlad?). To the approval-aviary person: after applying this patch and letting builds cycle through once, we'll then *safely* remove these two files to reduce download size a little (they were already removed once in a way that broke builds, so this'll just finish the job): mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensionAbout.png mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensionHome.png
Attachment #158362 -
Flags: approval-aviary?
Comment 5•20 years ago
|
||
Comment on attachment 158362 [details] [diff] [review] Removes files from jar.mn a=asa for aviary checkin.
Attachment #158362 -
Flags: approval-aviary? → approval-aviary+
Assignee | ||
Comment 6•20 years ago
|
||
Comment on attachment 158362 [details] [diff] [review] Removes files from jar.mn Per bug 256432 comment 15, I'm technically not allowed to check this in (without permission, that is). Can someone (vlad?) give me permission to do this, or can someone check this in for me?
Reporter | ||
Comment 7•20 years ago
|
||
(In reply to comment #6) > (From update of attachment 158362 [details] [diff] [review]) > Per bug 256432 comment 15, I'm technically not allowed to check this in > (without permission, that is). Can someone (vlad?) give me permission to > do this, or can someone check this in for me? Gaah, bug 256342 comment 15. No wonnder I haven't gotten a response yet. Anyways, /can/ someone give me permission to check this in (with cvs removal of the files a build cycle later)?
Status: NEW → ASSIGNED
Comment 8•20 years ago
|
||
Comment on attachment 158362 [details] [diff] [review] Removes files from jar.mn need re-approval now that we're past 1.0 RC. setting back to request.
Attachment #158362 -
Flags: approval-aviary+ → approval-aviary?
Comment 9•20 years ago
|
||
Comment on attachment 158362 [details] [diff] [review] Removes files from jar.mn too late for cleanup.
Attachment #158362 -
Flags: approval-aviary? → approval-aviary-
Assignee | ||
Comment 10•19 years ago
|
||
Okay, we never got around to checking it in last time, so let's try again, and let's axe with a little more finesse this time. The following links should be enough to confirm that everything that's getting removed is not actually used. The only results for these things are in CSS code (or jar.mn packaging) which matches nothing in source code: http://lxr.mozilla.org/mozilla/search?string=extension-button http://lxr.mozilla.org/mozilla/search?string=homepage-button http://lxr.mozilla.org/mozilla/search?string=options-button http://lxr.mozilla.org/mozilla/search?string=about-button http://lxr.mozilla.org/mozilla/search?string=extensionHome.png http://lxr.mozilla.org/mozilla/search?string=extensionAbout.png Note that pinstripe's extensionOptions.png can't be removed because it's used elsewhere in a spot that's still relevant: http://lxr.mozilla.org/mozilla/search?string=extensionOptions.png http://lxr.mozilla.org/mozilla/source/toolkit/themes/pinstripe/mozapps/extensions/extensions.css#103 http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/extensions/content/extensions.xul#281 extensionOptions.png is otherwise unused in winstripe/qute, however, so it's been removed in those themes.
Attachment #158362 -
Attachment is obsolete: true
Attachment #183836 -
Flags: review?(kevin)
Comment 11•19 years ago
|
||
Comment on attachment 183836 [details] [diff] [review] Remove extension(About|Home|Options).png and associated unused code Looks good. Thanks Jeff
Attachment #183836 -
Flags: review?(kevin) → review+
Assignee | ||
Updated•19 years ago
|
Attachment #183836 -
Flags: approval-aviary1.1a1?
Comment 12•19 years ago
|
||
Comment on attachment 183836 [details] [diff] [review] Remove extension(About|Home|Options).png and associated unused code a=asa
Attachment #183836 -
Flags: approval-aviary1.1a1? → approval-aviary1.1a1+
Comment 13•19 years ago
|
||
(In reply to comment #10) > Created an attachment (id=183836) [edit] Looks like you have accidentaly typed unwanted character in mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css - square bracket at the begginnig causes error displayed in JS console because of bad selector.
Assignee | ||
Comment 14•19 years ago
|
||
(In reply to comment #13) > Looks like you have accidentaly typed unwanted character in > mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css Oops - typo correction checked in. Anyway, patch is in and files were removed, so marking FIXED.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•