Closed Bug 258709 Opened 20 years ago Closed 20 years ago

Expansion of voteremovedmail should honour emailsuffix

Categories

(Bugzilla :: Email Notifications, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: Wurblzap, Assigned: Wurblzap)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; de-DE; rv:1.7) Gecko/20040707 Firefox/0.9.2
Build Identifier: Bugzilla 2.19

This is a follow-up bug of bug 256762.

Reproducible: Always
Steps to Reproduce:
Attached patch PatchSplinter Review
Comment on attachment 158409 [details] [diff] [review]
Patch

People might have worked around this bug by appending the emailsuffix in the
voteremovedmail parameter. I think it may be a good thing to mention in the
release notes to remove any emailsuffix in voteremovedmail.
Attachment #158409 - Flags: review?
Flags: blocking2.20?
Attachment #158409 - Flags: review? → review?(kiko)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Bug 256762 went into 2.18, so this should, too, I think.
Assignee: justdave → wurblzap
Flags: blocking2.18?
(In reply to comment #3)
> Bug 256762 went into 2.18, so this should, too, I think.

sure.
Flags: blocking2.20?
Flags: blocking2.20+
Flags: blocking2.18?
Flags: blocking2.18+
Target Milestone: --- → Bugzilla 2.18
Whiteboard: patch awaiting review
Comment on attachment 158409 [details] [diff] [review]
Patch

This looks good and doesn't seem to appear elsewhere inside the file.

Not sure about the identation of the dot (no spaces around it), but that's a
nit.
Attachment #158409 - Flags: review?(kiko)
Attachment #158409 - Flags: review?
Attachment #158409 - Flags: review+
Attachment #158409 - Flags: review?
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval2.18?
Whiteboard: patch awaiting review → patch awaiting approval
Flags: approval?
Flags: approval2.18?
Flags: approval2.18+
Flags: approval+
Whiteboard: patch awaiting approval → patch awaiting checkin
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.277; previous revision: 1.276
done

Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.270.2.2; previous revision: 1.270.2.1
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Whiteboard: patch awaiting checkin
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: