Closed Bug 258788 Opened 18 years ago Closed 18 years ago

Reflect GNOME Default shortcuts in the UI

Categories

(Firefox :: Menus, defect)

1.0 Branch
x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox1.0

People

(Reporter: p_ch, Assigned: p_ch)

References

Details

(Keywords: fixed-aviary1.0)

Attachments

(1 file)

The following patch does the following for GNOME:
- shift-ctrl-Z for redo
- ctrl-A for select all
- ctrl-Y for the download manager

in addition for the mac, it shows shift-accel-Z for redo (that's one that we
actually implement) instead of accel-Y, as specified in the apple HIG.
(http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/XHIGMenus/chapter_7_section_4.html#//apple_ref/doc/uid/TP30000356/TPXREF127,
in the undo section)

For the Ctrl-K part, I just moved its duplicated definition out of the #ifdef
since it's now a xp shortcut and commented to make clear that ctrl-J is still
needed in case the user has chosen the emacs bindings.
Attached patch patchSplinter Review
Comment on attachment 158478 [details] [diff] [review]
patch

requesting r=bryner, a=ben
Attachment #158478 - Flags: review?(bryner)
Attachment #158478 - Flags: approval-aviary?
msg from pch to aviary:

Since bryner's native keybinding patch has landed I think that the GNOME default
edit keybindings should be reflected in the UI (ctrl-A, shift-ctrl-Z). I've
written a patch in bug 258788. and I am requesting a quick r=bryner and a=ben if
it's not too late. I won't be able to check it in before sth like 11-12pm EST,
so feel free to drive it if it is approved.

pch
Flags: blocking-aviary1.0PR?
bryner not sure about the patch, so we should just consider this for final at
this point.
Flags: blocking-aviary1.0PR?
Flags: blocking-aviary1.0PR-
Flags: blocking-aviary1.0?
Attachment #158478 - Flags: review?(bryner) → review+
Blocks: 258684
Comment on attachment 158478 [details] [diff] [review]
patch

a=asa (on behalf of the aviary team) for checkin to the aviary branch.
Attachment #158478 - Flags: approval-aviary? → approval-aviary+
pch checked this into aviary on 2004-09-16 12:05.
Flags: blocking-aviary1.0?
Keywords: fixed-aviary1.0
Shouldn't this bug be closed? The patch has been applied and it works for me in
the 1.0 RC
Whiteboard: needs trunk checkin
Target Milestone: --- → Firefox1.0
Fixed on trunk by the aviary landing.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: needs trunk checkin
QA Contact: bugzilla → menus
You need to log in before you can comment on or make changes to this bug.