[AltSS] Switching stylesheets in print preview crashes browser

RESOLVED DUPLICATE of bug 259005

Status

()

Firefox
General
--
critical
RESOLVED DUPLICATE of bug 259005
14 years ago
12 years ago

People

(Reporter: Jim Ginn, Assigned: fantasai)

Tracking

1.0 Branch
Points:
---
Bug Flags:
blocking-aviary1.0PR -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: Talkback ID: TB777257X, TB777303Z, URL)

Attachments

(1 attachment)

(Reporter)

Description

14 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040910 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040910 Firefox/0.10

Switching stylesheets in print preview using the AltSS icon on the statusbar
will crash Firefox.

This was first reported by starwed in the MZ Forums:
http://forums.mozillazine.org/viewtopic.php?p=778825&highlight=#778825. May be a
Dupe, but I didn't see anything while searching.

Reproducible: Always
Steps to Reproduce:
1. Go to http://www.w3.org/Style
2. File->Print Preview
3. Try and select an alternate stylesheet

Actual Results:  
Crash. (Sorry I don't have talkback installed, no stack)

Expected Results:  
Changed the stylesheet.

Solution: Easiest is probably just to remove the icon while in print preview.
(Reporter)

Updated

14 years ago
Version: unspecified → 1.0 Branch
(Reporter)

Updated

14 years ago
Flags: blocking-aviary1.0?
Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040910 Firefox/0.10

WFM

i even tried styleswitching while in printpreview, NO problem

Comment 2

14 years ago
no WFM. did not crash but contents were all replaced with whitespace.
(Reporter)

Comment 3

14 years ago
Ok, I did some more testing:

1. Load a website with alternate stylesheets and select print preview. Select
another stylesheet in the print preview window. Browser just closes.

2. Load the same website. Select a stylesheet other than the default one. Load
print preview. Select any stylesheet EXCEPT the default one. NO CRASH, preview
changes with the stylesheet change.

3. Repeat 2. Select the default stylesheet while in print preview. CRASH.

4. Load the same website. Select another stylesheet. Select back to the default
one. Load print preview. Select any stylesheet. CRASH.

Seems to be tied to the default stylesheet of the website.

Comment 4

14 years ago
(In reply to comment #0)
> 1. Go to http://www.w3.org/Style
> 2. File->Print Preview
> 3. Try and select an alternate stylesheet
> 
> Actual Results:  
> Crash. (Sorry I don't have talkback installed, no stack)

No crash but high activity of harddisk and Firefox freeze.
Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20040910 Firefox/0.10

Comment 5

14 years ago
I see the same pattern as described in #3.
Using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040626
Firefox/0.9.1
(Reporter)

Comment 6

14 years ago
Dr. Watson reports: The exception generated was c0000005 at address 00625EF5
(firefox!nsRegionRectIterator__operator=)

Anyone got a talkback ID?

Comment 7

14 years ago
(In reply to comment #0)
> 1. Go to http://www.w3.org/Style
> 2. File->Print Preview
> 3. Try and select an alternate stylesheet

Crash (XP Home SP2): TB777257X
FYI: Same with FF 20040919 branch (zip, default profile): TB777303Z
(Reporter)

Comment 8

14 years ago
Marking All/All based on comment #4
Keywords: crash
OS: Windows XP → All
Hardware: PC → All
Whiteboard: Talkback ID: TB777257X, TB777303Z
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: crash
OS: All → Windows XP
Hardware: All → PC
Whiteboard: Talkback ID: TB777257X, TB777303Z
request ?10PR
Flags: blocking-aviary1.0PR?
(Reporter)

Comment 10

14 years ago
The best option here, probably, is to just hide the statusbar when in print
preview mode. IE already does this and it fixes the fact that other toolbar
icons can also persist (User visits cnn.com -> print preview -> Why is Firefox
blocking a pop-up when I try to print this page?). The only reason it might be
there is to remind the user that he/she is previewing a secure page. But, the
user should already know this from viewing the page.
OS: Windows XP → All
Hardware: PC → All
Whiteboard: Talkback ID: TB777257X, TB777303Z

Comment 11

14 years ago
Created attachment 158504 [details] [diff] [review]
Collapse AltSS icon when entering print preview

This doesn't solve the crash, but there probably isn't time for that before
1.0PR or maybe even 1.0. If we provide Alternate Print Stylesheet switching,
the icon should switch to serve that purpose in Print Preview.

This patch collapses the icon when in print preview mode, thus preventing a
user from crashing Firefox by using it. It's a simple bandaid, nothing more.

Comment 12

14 years ago
Comment on attachment 158504 [details] [diff] [review]
Collapse AltSS icon when entering print preview

Once again, requesting review so we can all get on with more important things
;)
Attachment #158504 - Attachment description: Collapses AltSS icon when entering print preview → Collapse AltSS icon when entering print preview
Attachment #158504 - Flags: review?(dbaron)
Does this show the icon when leaving print preview even when it otherwise
wouldn't have been?

Comment 14

14 years ago
It certainly shouldn't, and has not done so with my testing (although I admit,
it's hardly extensive).

1) Visit http://www.mozilla.org/products/firefox/
   - No AltSS icon
2) Print Preview
   - No AltSS icon
3) Cancel Print Preview
   - No AltSS icon
4) Visit http://www.w3.org/Style/
   - AltSS icon shown
5) Print Preview
   - No AltSS icon shown
6) Cancel Print Preview
   - AltSS icon shown
7) Visit http://www.mozilla.org/products/firefox/
   - No AltSS icon
8) Print Preview
   - No AltSS icon
9) Cancel Print Preview
   - No AltSS icon
(Assignee)

Comment 15

14 years ago
The AltSS switching code is screen-specific atm, so hiding it in Print Preview
is more than just a band-aid for this crash, it's necessary.

Comment 16

14 years ago
If there are alternate stylesheets with media=all or media=print, they should
still be offered as alternates for printing.

But hiding the UI to avoid the crash until this can be fixed properly is a good
idea.

Comment 17

14 years ago
I don't think this is going to be a common enough case to hold the release. 
Flags: blocking-aviary1.0PR?
Flags: blocking-aviary1.0PR-
Flags: blocking-aviary1.0?
Flags: blocking-aviary1.0+
(Reporter)

Comment 18

14 years ago
I filed Bug 259005 about the issue I mentioned in comment 10.

I still think that hiding the statusbar is the best approach, but the attached
patch looks good to me and should fix the crash.

Updated

14 years ago
Assignee: firefox → fantasai.bugs

Comment 19

14 years ago
dbaron, can you review and check in if all looks good?

Comment 20

14 years ago
Bug 259005 will hide the whole statusbar in print preview.

*** This bug has been marked as a duplicate of 259005 ***
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → DUPLICATE

Comment 21

14 years ago
Shouldn't this bug stay open, just non-blocking and non-critical?  The bug still
exists, it's just not possible to get to the UI that triggers it.  An extension
writer trying to add style switching functionality to the print preview might
run into it, for example.

Updated

14 years ago
Flags: blocking-aviary1.0+
Comment on attachment 158504 [details] [diff] [review]
Collapse AltSS icon when entering print preview

clearing review request that seems obsolete.  Re-request if it's not.
Attachment #158504 - Flags: review?(dbaron)
You need to log in before you can comment on or make changes to this bug.