258800 - [AltSS] Switching stylesheets in print preview crashes browser

Status: RESOLVED DUPLICATE of bug 259005

(Firefox :: General, defect)

Description

[Jim Ginn]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040910 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040910 Firefox/0.10

Switching stylesheets in print preview using the AltSS icon on the statusbar
will crash Firefox.

This was first reported by starwed in the MZ Forums:
http://forums.mozillazine.org/viewtopic.php?p=778825&highlight=#778825. May be a
Dupe, but I didn't see anything while searching.

Reproducible: Always
Steps to Reproduce:
1. Go to http://www.w3.org/Style
2. File->Print Preview
3. Try and select an alternate stylesheet

Actual Results:  
Crash. (Sorry I don't have talkback installed, no stack)

Expected Results:  
Changed the stylesheet.

Solution: Easiest is probably just to remove the icon while in print preview.

Comment 1

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040910 Firefox/0.10

WFM

i even tried styleswitching while in printpreview, NO problem

Comment 2

[Michael Favia]

no WFM. did not crash but contents were all replaced with whitespace.

Comment 3

[Jim Ginn]

Ok, I did some more testing:

1. Load a website with alternate stylesheets and select print preview. Select
another stylesheet in the print preview window. Browser just closes.

2. Load the same website. Select a stylesheet other than the default one. Load
print preview. Select any stylesheet EXCEPT the default one. NO CRASH, preview
changes with the stylesheet change.

3. Repeat 2. Select the default stylesheet while in print preview. CRASH.

4. Load the same website. Select another stylesheet. Select back to the default
one. Load print preview. Select any stylesheet. CRASH.

Seems to be tied to the default stylesheet of the website.

Comment 4

[Volkmar W. Pogatzki]

(In reply to comment #0)
> 1. Go to http://www.w3.org/Style
> 2. File->Print Preview
> 3. Try and select an alternate stylesheet
> 
> Actual Results:  
> Crash. (Sorry I don't have talkback installed, no stack)

No crash but high activity of harddisk and Firefox freeze.
Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20040910 Firefox/0.10

Comment 5

[Tim Martin]

I see the same pattern as described in #3.
Using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040626
Firefox/0.9.1

Comment 6

[Jim Ginn]

Dr. Watson reports: The exception generated was c0000005 at address 00625EF5
(firefox!nsRegionRectIterator__operator=)

Anyone got a talkback ID?

Comment 7

[Oliver Saier]

(In reply to comment #0)
> 1. Go to http://www.w3.org/Style
> 2. File->Print Preview
> 3. Try and select an alternate stylesheet

Crash (XP Home SP2): TB777257X
FYI: Same with FF 20040919 branch (zip, default profile): TB777303Z

Comment 8

[Jim Ginn]

Marking All/All based on comment #4

Comment 9

[Peter van der Woude [:Peter6]]

request ?10PR

Comment 10

[Jim Ginn]

The best option here, probably, is to just hide the statusbar when in print
preview mode. IE already does this and it fixes the fact that other toolbar
icons can also persist (User visits cnn.com -> print preview -> Why is Firefox
blocking a pop-up when I try to print this page?). The only reason it might be
there is to remind the user that he/she is previewing a secure page. But, the
user should already know this from viewing the page.

Comment 11

[Ben Basson]

Attachment: Collapse AltSS icon when entering print preview

This doesn't solve the crash, but there probably isn't time for that before
1.0PR or maybe even 1.0. If we provide Alternate Print Stylesheet switching,
the icon should switch to serve that purpose in Print Preview.

This patch collapses the icon when in print preview mode, thus preventing a
user from crashing Firefox by using it. It's a simple bandaid, nothing more.

Comment 12

[Ben Basson]

Comment on attachment 158504 [details] [diff] [review]
Collapse AltSS icon when entering print preview

Once again, requesting review so we can all get on with more important things
;)

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Does this show the icon when leaving print preview even when it otherwise
wouldn't have been?

Comment 14

[Ben Basson]

It certainly shouldn't, and has not done so with my testing (although I admit,
it's hardly extensive).

1) Visit http://www.mozilla.org/products/firefox/
   - No AltSS icon
2) Print Preview
   - No AltSS icon
3) Cancel Print Preview
   - No AltSS icon
4) Visit http://www.w3.org/Style/
   - AltSS icon shown
5) Print Preview
   - No AltSS icon shown
6) Cancel Print Preview
   - AltSS icon shown
7) Visit http://www.mozilla.org/products/firefox/
   - No AltSS icon
8) Print Preview
   - No AltSS icon
9) Cancel Print Preview
   - No AltSS icon

Comment 15

[fantasai]

The AltSS switching code is screen-specific atm, so hiding it in Print Preview
is more than just a band-aid for this crash, it's necessary.

Comment 16

[Greg Campbell]

If there are alternate stylesheets with media=all or media=print, they should
still be offered as alternates for printing.

But hiding the UI to avoid the crash until this can be fixed properly is a good
idea.

Comment 17

[Asa Dotzler [:asa]]

I don't think this is going to be a common enough case to hold the release. 

Comment 18

[Jim Ginn]

I filed Bug 259005 about the issue I mentioned in comment 10.

I still think that hiding the statusbar is the best approach, but the attached
patch looks good to me and should fix the crash.

Comment 19

[chris hofmann]

dbaron, can you review and check in if all looks good?

Comment 20

[Steffen Wilberg]

Bug 259005 will hide the whole statusbar in print preview.

*** This bug has been marked as a duplicate of 259005 ***

Comment 21

[Tim Martin]

Shouldn't this bug stay open, just non-blocking and non-critical?  The bug still
exists, it's just not possible to get to the UI that triggers it.  An extension
writer trying to add style switching functionality to the print preview might
run into it, for example.

Comment 22

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 158504 [details] [diff] [review]
Collapse AltSS icon when entering print preview

clearing review request that seems obsolete.  Re-request if it's not.