258801 - it doesn't build if a patch isn't applied on nsProfileMigrator.cpp

Status: RESOLVED FIXED

(Thunderbird :: Migration, defect)

Description

[François Vincent]

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8a3) Gecko/20040829
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8a3) Gecko/20040829

at ImportRegistryProfiles it should be added:

#elif defined(XP_BEOS)
  rv = dirService->Get(NS_BEOS_SETTINGS_DIR, NS_GET_IID(nsILocalFile),
                       getter_AddRefs(regFile));
  NS_ENSURE_SUCCESS(rv, PR_FALSE);
  regFile->AppendNative(aAppName);
  regFile->AppendNative(NS_LITERAL_CSTRING("appreg"));

Reproducible: Always
Steps to Reproduce:
1. Try to build Thunderbird for BeOS
2.
3.

Actual Results:  
It doesn't build.

Expected Results:  
a Thunderbird build.

Comment 1

[François Vincent]

I forgot to say that the file nsProfileMigrator.cpp is the one placed at
mozilla/mail/components/migration/src

Comment 2

[François Vincent]

Attachment: a defined for a BeOS build

Comment 3

[tqh]

Comment on attachment 158496 [details] [diff] [review]
a defined for a BeOS build

review request

Comment 4

[Sergei Dolgov]

See comment
http://bugzilla.mozilla.org/show_bug.cgi?id=258804#c3

If we decide that we need this mail migration for (future) sake, i'll review
both patches, but maybe better idea is get rid from all that for ever?:)

Comment 5

[tqh]

You mean not build migration at all?

I don't know if there is a flag for that. If there isn't it's hard to build
without bug 258801, 258804, 258806

Comment 6

[tqh]

Saw your post in bug 258804 and I think it would be a good idea if it's able to
work without it.

Comment 7

[Sergei Dolgov]

(In reply to comment #6)
> Saw your post in bug 258804 and I think it would be a good idea if it's able to
> work without it.
I'd set topic in Bezilla blog about the problem:
http://www.livejournal.com/community/bezilla/52509.html
Maybe it is reasonable to allow such kind of Be mail "import" into gecko family
apps. E.g in order to move/copy BeOS mail data to windows/linux. That's why i
asked you there about explanations. E.g. ig this feature allows complete (with
mail messages) account import.

Comment 8

[Sergei Dolgov]

Comment on attachment 158496 [details] [diff] [review]
a defined for a BeOS build

r=[e-mail]

Comment 9

[Benjamin Smedberg]

What's the status of this bug?

Comment 10

[tqh]

I assume it's still there and needs fixing, but I don't work on Thunderbird.

Comment 11

[Sergei Dolgov]

Comment on attachment 158496 [details] [diff] [review]
a defined for a BeOS build

timeless, are you allowed to sr Thunderbird BeOS bugs?
(also need someone for checkin)

Comment 12

[timeless]

well, it's clearly in an ifdef, but i'm neither an sr nor anything in thunderbird. i have no idea if there are 
porting graces allowed for this product.

Comment 13

[timeless]

Comment on attachment 158496 [details] [diff] [review]
a defined for a BeOS build

mozilla/mail/components/migration/src/nsProfileMigrator.cpp 	1.9