258806 - it doesn't build if a patch isn't applied at nsModule.cpp

Status: RESOLVED FIXED

(Thunderbird :: Migration, defect)

Description

[François Vincent]

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8a3) Gecko/20040829
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8a3) Gecko/20040829

Dogbert is not needed to be build in a BeOS build, so nsModule.cpp in
mozilla/mail/components/build should get some defineds like this:

...
#if !defined(XP_BEOS)
#include "nsDogbertProfileMigrator.h"
#endif
...
#if !defined(XP_BEOS)
NS_GENERIC_FACTORY_CONSTRUCTOR(nsDogbertProfileMigrator)
#endif
...
#if !defined(XP_BEOS) 
 { "Netscape Communicator 4.x",
    NS_DOGBERTPROFILEMIGRATOR_CID,
    NS_MAILPROFILEMIGRATOR_CONTRACTID_PREFIX "dogbert",
    nsDogbertProfileMigratorConstructor },
#endif

Reproducible: Always
Steps to Reproduce:
1. Try to build Thunderbird
2.
3.

Actual Results:  
It doesn't build.

Expected Results:  
A Thunderbird build

Comment 1

[François Vincent]

Attachment: patch for definded's in mozilla/mail/components/build

Comment 2

[tqh]

Franxico, this patch doesn't look right.

These shouldn't be there:
+  { "Netscape 4.x Profile Migrator",
+    NS_DOGBERTPROFILEMIGRATOR_CID,
+    NS_BROWSERPROFILEMIGRATOR_CONTRACTID_PREFIX "dogbert",
+    nsDogbertProfileMigratorConstructor },

Maybe you should reget that file from CVS and redo the patch.

Comment 3

[François Vincent]

Attachment: patch to avoid dogbert

Comment 4

[tqh]

Comment on attachment 158537 [details] [diff] [review]
patch to avoid dogbert

review request

Comment 5

[tqh]

add dependency

Comment 6

[Sergei Dolgov]

Comment on attachment 158537 [details] [diff] [review]
patch to avoid dogbert

r=sergei_d

Comment 7

[Benjamin Smedberg]

What's the status here?

Comment 8

[tqh]

I assume it's still there and needs fixing, but I don't work on Thunderbird.

Comment 9

[Sergei Dolgov]

Comment on attachment 158537 [details] [diff] [review]
patch to avoid dogbert

timeless, can you sr and checkin this?

Comment 10

[timeless]

i'm not an sr, and see other comments.

Comment 11

[timeless]

Comment on attachment 158537 [details] [diff] [review]
patch to avoid dogbert

mozilla/mail/components/build/nsModule.cpp 	1.3