258856 - With 'always use this default char. encoding when replying' set, the recipient name got mangled

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Jungshik Shin]

If 'always use this default char. encoding in replies ' is checked in Edit |
Pref | Mail &News | Composition,  the name of the recipient in the composition
window got mangled if it has non-ASCII characters. That's because 'To:' (and
Reply-To/CC) are interpreted as if it(they) were in the default send-character
encoding which can be different from the character encoding of the message being
replied to. 

I'm gonna upload a patch shortly.

Comment 1

[Jungshik Shin]

Attachment: patch

Comment 2

[Jungshik Shin]

*** Bug 258855 has been marked as a duplicate of this bug. ***

Comment 3

[Jungshik Shin]

Comment on attachment 158529 [details] [diff] [review]
patch

asking for r/sr

Comment 4

[David :Bienvenu]

Comment on attachment 158529 [details] [diff] [review]
patch

+      rv = msgHdr->GetSubject(getter_Copies(subjectCStr));

since we're blowing off this error (which is the right thing to do, I think),
could you make it:

(void) msgHdr->GetSubject...

r=bienvenu with that nit

Comment 5

[Scott MacGregor]

jshin, is this a recent regression or something that we've always done
incorrectly? If it's always been this way, I may port this patch to the aviary
branch. Though I'd ask. 

Comment 6

[Jungshik Shin]

thanks for r/sr.  fix checked into the trunk

Scott, 
I think this patch (along with the patch for bug 260725) needs to be ported to
the branch because the patch that introduced this option ('always use the
default char. encoding when replying' and this problem ('Sender' address getting
mangled with the option on) was   in the branch (bug 234958). In case of the
subject address (the other problem I'm fixing here), it's been like that (it
ignored the char. encoding override and always used 'charset' specified in RFC
2047-style header like =?ISO-8859-1?Q?......?) for a long time, which is another
reason to fix this on the branch as well. 

Comment 7

[Jungshik Shin]

Comment on attachment 158529 [details] [diff] [review]
patch

Asking for a to branches. 

I've just applied the patch to the 1.7branch and built it. It worked fine as
expected.

Comment 8

[Scott MacGregor]

Comment on attachment 158529 [details] [diff] [review]
patch

I'll check this into aviary

Comment 9

[Mike Kaply [:mkaply]]

Comment on attachment 158529 [details] [diff] [review]
patch

Assuming this options is in 1.7, a=mkaply for 1.7