259211 - startSoftwareUpdate() should send install-blocked notification to UI

Status: RESOLVED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Daniel Veditz [:dveditz]]

The InstallTrigger.startSoftwareUpdate trigger does not send UI notifications
when an install attempt was blocked. This method is used on several mozdev.org
projects among others. It's a deprecated method, but still popular because the
arguments are simple.

Comment 1

[Daniel Veditz [:dveditz]]

Attachment: send notification when startSoftwareUpdate blocked

Comment 2

[Daniel Veditz [:dveditz]]

Comment on attachment 158832 [details] [diff] [review]
send notification when startSoftwareUpdate blocked

review note: this code block is now identical with the analogous place in
InstallTriggerGlobalInstall(). a r+sr should be sufficient

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 158832 [details] [diff] [review]
send notification when startSoftwareUpdate blocked

r+sr=me if you change that to:

if (os && globalObject) {

in the 3 or so places this code pattern appears.

Comment 4

[Daniel Veditz [:dveditz]]

Fix checked into aviary. This notification code only exists on the aviary branch.

mkaply: this was part of the "silently failing" installs issue. bug 258798 was a
problem for some sites, but with or without an updateEnabled() problem any site
that used InstallTrigger.startSoftwareUpdate() would never get an info bar when
blocked.