Closed
Bug 259235
Opened 20 years ago
Closed 19 years ago
Sanity-Check Alarms Panel Inputs in Options
Categories
(Calendar :: General, defect)
Calendar
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: anupama, Assigned: jminta)
Details
Attachments
(1 file)
4.63 KB,
patch
|
mattwillis
:
first-review+
mvl
:
second-review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/4.0 (compatible; MSIE 5.01; Windows NT 5.0)
Build Identifier: Default time Alarm goes off before an event accepts negative integer
Tools->Options->Alarms.Negative value is accepted.
Reproducible: Always
Steps to Reproduce:
1. Click Tools->Options->Alarms
2. Double click the "Default time Alarm goes off before an event " field
3. Enter negative Integer eg - 60
Actual Results:
1. The field accepts the negative integer
Expected Results:
1. By default it should take as blank/0 or display an error message
there is no Tools / Options
there is no Tools / Options / Alarms
Summary: Default time Alarm goes off before an event accepts negative integer → Default time Alarm goes off before an event accepts negative integer
Comment 2•20 years ago
|
||
Wm, you are wrong, there is in-fact Tools->Options then click button for
"Alarms" Pane, (in sunbird)
Change Sumary (to be concise), Mark-New
URL: No url
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 2000 → All
Hardware: PC → All
Summary: Default time Alarm goes off before an event accepts negative integer → Sanity-Check Alarms Panel Inputs in Options
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → INVALID
Comment 3•20 years ago
|
||
As I told Wm, this bug is valid.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Comment 4•20 years ago
|
||
*** Bug 259237 has been marked as a duplicate of this bug. ***
Comment 5•20 years ago
|
||
Ignore that. It's not a dupe once I reread the thing.
Updated•19 years ago
|
QA Contact: gurganbl → general
Comment 6•19 years ago
|
||
Reassigning all automatically assigned bugs from Mostafa to nobody@m.o
Bugspam filter: TorontoMostafaMove
Assignee: mostafah → nobody
Status: REOPENED → NEW
Assignee | ||
Comment 7•19 years ago
|
||
Patch makes sure that we only end up with positive whole numbers. Asking the pref-guru for first-review. With this function, we can bulletproof several other of our prefs as well.
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #229207 -
Flags: first-review?(mattwillis)
Comment 8•19 years ago
|
||
Comment on attachment 229207 [details] [diff] [review]
ensure natural numbers
Prevailing style of that file is "function ... \n { \n".
Personally I consider the way you wrote it The Right Way.
You decide if you want to change it or not.
r=lilmatt, with that
Attachment #229207 -
Flags: first-review?(mattwillis) → first-review+
Assignee | ||
Comment 9•19 years ago
|
||
Comment on attachment 229207 [details] [diff] [review]
ensure natural numbers
and...second review time.
Attachment #229207 -
Flags: second-review?(mvl)
Comment 10•19 years ago
|
||
Comment on attachment 229207 [details] [diff] [review]
ensure natural numbers
r=mvl
Attachment #229207 -
Flags: second-review?(mvl) → second-review+
Assignee | ||
Comment 11•19 years ago
|
||
patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago → 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•