259500 - Input height calculated incorrectly, weird margin for input[type="text"] when border is present

Status: RESOLVED EXPIRED

(Core Graveyard :: GFX: Win32, defect)

Description

[CyberAlien]

User-Agent:       Opera/7.54 (Windows NT 5.0; U)  [en]
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10

In example url there are 2 inputs - input[type="text"] and input[type="submit"]. 
Both are supposed to be 20px high (22 if count border), but input[type="text"] 
is shown as 22px high and input[type="submit"] is shown as 18px high and in 
addition input[type="text"] has weird margin on top. 

It happens with all Mozilla builds.

Reproducible: Always
Steps to Reproduce:
1. create input with type=text and with type=submit
2. set height: 20px for both inputs and 1px border


Actual Results:  
You'll see input[type="text"] with height=22px and input[type="submit"] with 
height=18px. And if both inputs are in same line then input[type="text"] will 
have weird margin on top.

Expected Results:  
It should have shown both inputs with height=20px (22px if include border in 
height) and no top margin. And both inputs should have been placed vertically on 
the same line

Happens with all Mozilla builds for all operating systems regardless of 
configuration. 

I consider margin for input[type="text"] a major bug because inputs on pages 
look awful and I have to use css hacks to show it correctly. Height problem can 
be fixed by using different height for different inputs (but then it would look 
incorrectly with Opera because Opera counts height correctly), but margin 
problem can't be fixed and it causes lots of problems with designs.

Comment 1

[CyberAlien]

Attachment: Testcase

Comment 2

[Ng Ming Hong]

Attachment: Counter example

I think this should be invalid. Because form widgets are OS-dependent...

The "problem" seems to relate to the presence of border. I've made a test case
where the input has no border. They are of the same height then.

Comment 3

[CyberAlien]

Yes, looks like problem appears only when border is set.
I have added "when border is present" to title of bug report.

Comment 4

[Boris Zbarsky [:bzbarsky]]

The height issue is quite purposeful.  The text input does content-box sizing
("height" doesn't include border), while the button does border-box sizing
("height" includes border).  The reasons for this are discussed in the relevant
bugs (don't have bug numbers offhand, but look at the CVS log for forms.css).

The weird margin must be a Win32 nsITheme thing -- I'm not seeing it on current
Linux trunk.  Over to Win32 GFX.

Comment 5

[Ere Maijala (slow)]

Does this actually have something to do with OS/2 or is the component wrong?

Comment 6

[Ere Maijala (slow)]

I read the comment again. It must be Win32..

Comment 7

[Ng Ming Hong]

This seems to be a problem of the box model for button, as suggested by ppk of
QuirksMode.org:
http://www.quirksmode.org/css/tests/mozie_button.html

Comment 8

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 9

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.