259724 - wrong behaviour of toolbarbutton when it is disabled

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[alexander :surkov (:asurkov)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040616
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040616

If disabled toolbarbutton has attributes type="radio" or type="checkbox" then
toolbarbutton is pressed on mouse click.

Reproducible: Always
Steps to Reproduce:
1 write: <toolbarbutton label="press me" type="checkbox" disabled="true"/>
2 click on the button
Actual Results:  
toolbarbutton will be checked

Expected Results:  
toolbarbutton should not be checked

Comment 1

[alexander :surkov (:asurkov)]

Attachment: test case

Comment 2

[[e-mail]]

Oops. Fallout from bug 230854 :-[

Comment 3

[Stefan Borggraefe]

Attachment: Patch

Comment 4

[[e-mail]]

Comment on attachment 159353 [details] [diff] [review]
Patch

>+              (this.autoCheck || !this.hasAttribute("autoCheck"))) {
>+
>+            if (this.type == "checkbox") {
Any particular reason for the blank line?

>       <handler event="click" button="0">
>       <![CDATA[
>-        if (this.autoCheck || !this.hasAttribute("autoCheck")) {
>-          if (this.type == "checkbox") {
>-            this.checked = !this.checked;
>-          } else if (this.type == "radio") {
>-            this.checked = true;
>-          }
>-        }
>+        this._handleClick();
>       ]]>
>       </handler>
This cleanup is nice but I think would be that little bit nicer using the
action attribute on the handler instead of a body.

Comment 5

[Stefan Borggraefe]

Attachment: Patch V1.1

Uses the action attribute of <handler>.

I think the blank line improves the readability of the code.

Comment 6

[[e-mail]]

Comment on attachment 159356 [details] [diff] [review]
Patch V1.1

r+sr=me although I'm not 100% convinced about the blank line...

Comment 7

[Stefan Borggraefe]

Fix checked in. (With the blank line.) ;-)

Comment 8

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1a2) Gecko/20060518 SeaMonkey/1.1a] (nightly) (W98SE)

V.Fixed (on MOZILLA_1_8_BRANCH), with testcase in bug 282180.