260158 - datepicker/timepicker menulist have blinking text cursor while popped up, but can't type

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: cvs-cal

Bug 259155 modified datepicker and timepicker to use menulist.
When the menupopup is popped up, the text cursor is still visible and blicking,
inviting you to type at it, but typing does nothing.

Reproducible: Always
Steps to Reproduce:
1. In event dialog, click on dropdown menulist button of datepicker or timepicker.

Actual Results:  
While the popup is popped up, the text cursor is still blinking in the text field.
Typing does nothing.

Expected Results:  
Cursor should not be visible and blinking.
One option is to select all the text, as it will all be replaced by clicking on
popup.  This seems to be what happens in the seamonkey and firefox urlbar.

Comment 1

[Justin Wood (:Callek)]

hmm...

In Seamonkey for me, text is not selected, and cursor stays blinking in the
url-bar.  though a text-select may be a decent solution until that text-blinking
bug is fixed.

----
See: Bug 259155 comment #8
----

Though I do agree a work-around is useful/needed for at least us, and select-all
on the text could work.

Comment 2

[gekacheka]

Attachment: datepicker.xbl, timepicker.xbl patch: select text on popup and on click date/time

Add code to select text on popup and when click on date or time in picker.

datepicker.onPopup():  add select text 
datepicker.clickDate():  add select text after it is changed
datepicker.select():  added method, like menulist.select or textbox.select

timepicker.onPopup(): add select text
timepicker.select(): added method

timepickergrids.timeSelected(): add select text after it is changed.

Comment 3

[gekacheka]

Comment on attachment 159275 [details] [diff] [review]
datepicker.xbl, timepicker.xbl patch: select text on popup and on click date/time

tested on SB 0.2a, Moz 1.7.3, TB 0.8

Comment 4

[Mostafa Hosseini]

Comment on attachment 159275 [details] [diff] [review]
datepicker.xbl, timepicker.xbl patch: select text on popup and on click date/time

In: 
		 this.update(new Date(aMiniMonthGrid.value), true)
+		 // select changed value so no cursor appears (can't type to
it).
+		 this.select();
+

shouldn't the first line end with a semicolon?

It's not related to the patch but still.

Comment 5

[Mostafa Hosseini]

Comment on attachment 159275 [details] [diff] [review]
datepicker.xbl, timepicker.xbl patch: select text on popup and on click date/time

Checked in.

Comment 6

[Mostafa Hosseini]

Fixed in CVS.
I'll add the semicolon once it is confirmed that it should be there.

Comment 7

[gekacheka]

Yes the semicolon should be there.  JavaScript is lenient about semicolons.

Comment 8

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!