26020 - resource files under mozilla/extensions/wallet need to be re-arranged

Status: RESOLVED FIXED

(SeaMonkey :: Passwords & Permissions, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

the resource files under mozilla/extensions wallet don't follow the tree rules.

for example, take cookieviewer.

we have:

./cookieviewer/CookieViewer.css
./cookieviewer/wallet.css
./cookieviewer/CookieViewer.xul
./cookieviewer/CookieViewer.js
./cookieviewer/CookieViewer.dtd
./cookieviewer/CookieViewer.properties

these should be reorganized like the rest of the resources in the tree:

dtd and properties files to cookieviewer/resources/locale/en-US
css and gif files cookieviewer/resources/skin
js and xul files cookieviewer/resources/content

the properties files are in the wackiest of places:

./cookieviewer/CookieViewer.properties
./editor/WalletEditor.properties
./signonviewer/SignonViewer.properties
./src/cookie.properties
./src/wallet.properties
./walletpreview/WalletPreview.properties 

this should be cleaned up.

assigning to ben goodger, monster of all things ui.

Comment 1

[don]

Should we fix this for beta 1?

Comment 2

[tao]

It's not a blocker; but, it won't take longer than an hour to move files around
and fixed the makefiles.

Comment 3

[Stephen P. Morse]

It's all under the hood.  If you want to do it, go ahead.  But it certainly 
shouldn't be needed for beta1.  And there's always a risk that you might break 
something by doing this.

Comment 4

[(not reading, please use [e-mail] instead)]

right, this is not a beta stopper.

it's just general source tree cleanup.

Comment 5

[don]

OK, M15.

Comment 6

[Sammy Ford]

im working on this now

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

sford says he's nailed this. thanks, sford!

Comment 8

[Stephen P. Morse]

Reopening.  There are now two copies of the files -- one in the original place 
and one in the new place.  The original files need to be removed from cvs.

For example, there is the file

   extensions/wallet/cookieviewer/CookieViewer.xul

and also the file

   extensions/wallet/cookieviewer/resources/content/CookieViewer.xul

Furthermore, the makefiles were not changed so the file in the original place is 
the one that is getting installed.

Comment 9

[Stephen P. Morse]

sford, can you please either finish this move or back out the changes that you 
made.  The way things stand now there are two versions of all the cookie/wallet 
resource files.  This is forcing me to make changes in two places whenever I 
need to modify one of the files in order to make sure that they don't get out of 
synch.

Comment 10

[Stephen P. Morse]

The situation that we currently have is untenable.  There are two copies of each 
of the resource files and the new copies that were added are not being used.  
This creates a maintenance nightmare because, unless extreme care is taken, the 
copies are going to get out of synch.  I have asked sford (the person who added 
the copies) to clean this up but to date I have received no response and nothing 
has been done about it.

Therefore I am going to make the following change before the M15 freeze this 
evening.  I will replace the new (currently unused) copies with empty files.  
This will insure that nobody puts any future changes in the new files by 
accident.

Comment 11

[Sammy Ford]

if you can review, i can finish this up tonight, and therefore it would be done 
with, and no further complications will result

Comment 12

[Stephen P. Morse]

Too late.  I just backed out the duplicate files.

Comment 13

[don]

Ben, is this resolved yet?

Comment 14

[Stephen P. Morse]

claudius, this can't possibly be nsbeta2.  It's completely "under the hood" and 
in no way visible to the users.

Comment 15

[leger]

Putting on [nsbeta2-] radar. Not critical to beta2.  Putting on nsbeta3 radar.  
When you have the time after PR2, yep, you should clean it up.:-)

Comment 16

[don]

Move to M20.

Comment 17

[sairuh (rarely reading bugmail)]

spam: mass-moving open password manager (single signon) and form manager
(autofill) bugs to Terri for qa contact. unfortunately, i cannot cc myself with
this form, so feel free and add me if you want to keep me in the loop with any
(but, pls not all :) of these... will also go thru 'em meself, a bit later...

Comment 18

[Marcia Knous [:marcia]]

Netscape nav triage team: based on Steve Morse's pretriage recommendation, this 
is not a beta stopper.

Comment 19

[cata]

This affects the localization team...

Comment 20

[Asa Dotzler [:asa]]

renominating per cata's comments.

Comment 21

[Chris McAfee]

-, back over to morse for a look.  If ben needs to do something, bounce back to
him.  Haven't seen input from Ben here recently.

Comment 22

[Cindy Roberts]

Marking nsbranch- as it was decided in the August bug triage that we wouldn't
have enough time in eMojo to fix this.  Let's revisit for MachV.

Comment 23

[Ying-Lin Xia]

Any update?
And why this is a l12y bug? I can see the dtd and properties in langenus.xpi, 
in the proper folder "locale/en-US/communicator/wallet". Is it only the tree 
structure issue?
Ray, do we have any problem for l10n with this bug? If not, we should remove 
the keyword.

Comment 24

[rchen]

Not a l12y bug. This is just a CVS clean-up job. There is no problem in the bin.

Comment 25

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Reassigning to new module owner.

Comment 26

[[e-mail]]

Attachment: patch to jar.mn

this fixes extensions/wallet/jar.mn to point to the correct locations, once the
files are moved.

Comment 27

[[e-mail]]

Comment on attachment 124554 [details] [diff] [review]
patch to jar.mn

requesting r/sr - but if you guys would rather dveditz looked at this, that's
fine ;)

this obviously covers moving the files as well, and removing the placeholders
that are there now. also, there's some cruft that can be removed:

./editor/WalletEditor.js & xul (they're not jarred, so...)
./src/cookie.properties
./src/resources/locale/en-US/cookie.properties (both these live in
extensions/cookie now)

Comment 28

[[e-mail]]

oh, one more thing - there are a bunch of .tbl files living in
extensions/wallet/src, which look like locale-specific things. i'm not sure if
they should stay there or be moved... any preference?

Comment 29

[Alec Flett]

I believe the .tbl stuff maps form/form field names (i.e. stuff like <form
name="foo"><input name="bar"></form>
in web pages to wallet fields. I don't THINK its locale-specific..

Comment 30

[[e-mail]]

hmm, ok - do you think resources/content might be a better home for it then, or
can it just stay where it is?

Comment 31

[timeless]

Comment on attachment 124554 [details] [diff] [review]
patch to jar.mn

you'll of course need to copy the file contents when you make this commit and
you should *cvs remove* the originals so that we don't end up in confusing
states as we have because of this bug in the past :)

Comment 32

[Heikki Toivonen (remove -bugzilla when emailing directly)]

The tbl files probably cause bug 114073. I don't think they can just be
localized. An architectural change would be needed, I think.

Comment 33

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Giving to Dan since he whipped up the patch, and setting a more realistic
milestone. Review to follow.

Comment 34

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Comment on attachment 124554 [details] [diff] [review]
patch to jar.mn

sr=heikki, although I would have preferred to see the cvs rm/add things in one
patch as well... If you copy files around, the best way would be to ask leaf to
copy the files on the CVS server which would maintain the CVS history on the
files. Then you would only need to cvs rm the old copies.

Comment 35

[[e-mail]]

thanks heikki - that other bug is interesting, i'll look at satchel sometime to
see if/how it does it. (we could still put the tbl's into resources/content per
comment 30 if you think that's a good idea).

thx for the suggestion about talking to leaf - will do! it'd be neat if i can
preserve blame for the files.

Comment 36

[[e-mail]]

fixed. props to leaf!