Closed Bug 260282 Opened 18 years ago Closed 18 years ago

<MARQUEE> default |Direction| should be "left", instead of "right"

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.8alpha4

People

(Reporter: sgautherie, Assigned: sgautherie)

Details

(Keywords: fixed-aviary1.0, fixed1.7.5, testcase)

Attachments

(1 file, 1 obsolete file)

This comes from bug 207340 comment 7:
{{
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a3) Gecko/20040817] (release) (W98SE)
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.3) Gecko/20040910] (release) (W98SE)
[Microsoft Internet Explorer, version 5 (5.00.3105.0106) (128b, SP1)] (<-- =
v5.01) (W98SE)

<marquee direction="L">

the marquees scroll right instead of left.
}}

<http://msdn.microsoft.com/workshop/author/dhtml/reference/properties/direction.asp>
says
{{
left	Default. Marquee scrolls left.
right	Marquee scrolls right.
down	Marquee scrolls down.
up	Marquee scrolls up.
}}

|"L"| value is invalid, then should default to left !
Enforce Microsoft specification :-/
Assignee: nobody → gautheri
Status: NEW → ASSIGNED
Attachment #159345 - Flags: superreview?(bryner)
Attachment #159345 - Flags: review?(neil.parkwaycc.co.uk)
OS: Windows 98 → All
Hardware: PC → All
Summary: <MARQUEE> going the wrong Direction → <MARQUEE> default |Direction| should be "left", instead of "right"
Comment on attachment 159345 [details] [diff] [review]
(Av1) <xbl-marquee.xml>
[Checked in: Comment 11]

Over to owner of marquee.
Attachment #159345 - Flags: review?(neil.parkwaycc.co.uk) → review?(doronr)
May I point out that this is a small deficiency,
when in Mail/News the only functionality for Marquee
is the default behavior
See Bug 240262
(In reply to comment #4)
> See Bug 240262

I'm not using ThunderBird, so I can't comment on your bug.
Comment on attachment 159345 [details] [diff] [review]
(Av1) <xbl-marquee.xml>
[Checked in: Comment 11]

You probably don't need sr since you are just moving code around :)
Attachment #159345 - Flags: review?(doronr) → review+
Attachment #159345 - Flags: superreview?(bryner) → superreview+
Attachment #159345 - Flags: approval1.7.x?
Attachment #159345 - Flags: approval-aviary?
Comment on attachment 159345 [details] [diff] [review]
(Av1) <xbl-marquee.xml>
[Checked in: Comment 11]

a=asa for branches checkin.
Attachment #159345 - Flags: approval1.7.x?
Attachment #159345 - Flags: approval1.7.x+
Attachment #159345 - Flags: approval-aviary?
Attachment #159345 - Flags: approval-aviary+
Attachment #159345 - Flags: approval1.8a4?
Keywords: fixed1.7.x
Comment on attachment 159345 [details] [diff] [review]
(Av1) <xbl-marquee.xml>
[Checked in: Comment 11]


Check in: { 2004-09-25 06:03	neil%parkwaycc.co.uk	mozilla/ layout/ html/
document/ src/ xbl-marquee/ resources/ content/ xbl-marquee.xml  1.8.2.1       
 MOZILLA_1_7_BRANCH }
fixed on aviary branch
Keywords: fixed-aviary1.0
Comment on attachment 159345 [details] [diff] [review]
(Av1) <xbl-marquee.xml>
[Checked in: Comment 11]

can't hurt. a=asa for 1.8a4 checkin.
Attachment #159345 - Flags: approval1.8a4? → approval1.8a4+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Attachment #159345 - Attachment description: (Av1) <xbl-marquee.xml> → (Av1) <xbl-marquee.xml> [Checked in: Comment 11]
Attachment #159345 - Attachment is obsolete: true
Target Milestone: --- → mozilla1.8alpha4
The default behaviour should depend on the text direction <marquee> inherits:
wether it is RTL or LTR.

The direction for the document itself can be found at document.dir
But elements inside the document, including <marquee> ancestors, may change
direction via dir= attribute.

In simple terms default <marquee> behaviour should be LEFT for English
documents, and RIGHT for Arabic documents.

Default direction may also depend on the base direction of the text contained
inside <marquee>.

As in, even while document may be LTR, for a <marquee> containing Arabic text
with no other markup instructions, the smart default thing would be to do a
RIGHT scroll.
hmmmm
on the second thought, default scroll direction should not depend on
document/ancestor direction.

It should only depend on the base direction of the contained text.

An English document may be RTL for all kinds of weird presentational reasons.
But trying to read English sentence as it scrolls out from it's end is just
demented.

This behaviour may be very difficult to achieve if not impossible.
I don't see any properties on DOM text nodes that may indicate their base direction.
My patch fixed only the "default=LTR" case.

I agree that the text direction could change the default behaviour to RTL;
but I too don't know how to do it.
You need to log in before you can comment on or make changes to this bug.