260362 - Roaming window has a placeholder title

Status: RESOLVED FIXED

(Core Graveyard :: Profile: Roaming, defect)

Description

[Luke Reeves]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040917 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040917 Firefox/0.9.3

The roaming window has a placeholder title ("Roaming transfer: %transfer%")
instead of a real one.

Reproducible: Always
Steps to Reproduce:
Start a roaming transfer.
Actual Results:  
The window title contains the "%title%" word.


I'll attach a screenshot.

Comment 1

[Luke Reeves]

Attachment: Window shot of the title in question.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Is this a problem with trunk Mozilla builds?  Or just Firefox branch ones, as
you comments indicate?

Comment 3

[Luke Reeves]

Sorry, the comment was posted from Firefox, but the bug occurs in the Mozilla trunk.

Comment 4

[Frank Wein [:mcsmurf]]

Attachment: Patch

I think we should just remove the %title% there since noone knows what the %title% should be (not even the original creator of the code).

Comment 5

[[e-mail]]

Comment on attachment 230254 [details] [diff] [review]
Patch

If this is a static string then it should be in a .dtd

Comment 6

[Frank Wein [:mcsmurf]]

Attachment: Patch 2 [checked in on trunk and MOZILLA_1_8_BRANCH]

The dialog already has a title within the DTD/XUL (see progressDialog.xul) so I guess we can remove it.

Comment 7

[Frank Wein [:mcsmurf]]

Comment on attachment 230258 [details] [diff] [review]
Patch 2 [checked in on trunk and MOZILLA_1_8_BRANCH]

Not sure if you are the right group to give approval for this patch since roaming code is atm only used by SeaMonkey...

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 230258 [details] [diff] [review]
Patch 2 [checked in on trunk and MOZILLA_1_8_BRANCH]

a=drivers. Please go ahead and land this on the branch.