260458 - Collect file commands in file menu, and separate new/open calendar to avoid warning "already exists. do you want to replace it"

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: cvs-cal

Expect commands for calendar files to be in the File menu, but some are hidden
in the Tools menu.  Suggest collecting them into the file menu.

The 'new calendar' command does double duty as 'open calendar' command, but this
can be confusing (at least on windows platform) because it uses the file picker
in 'save' mode, which warns about overwriting an existing file even when trying
to open that file.  Therefore suggest separating New and Open functions so that
the Open function can use the file picker in "open" mode rather than "save"
mode.  Previous discussion:
http://bugzilla.mozilla.org/show_bug.cgi?id=170190#c4
http://bugzilla.mozilla.org/show_bug.cgi?id=243799#c3

Reproducible: Always
Steps to Reproduce:
Open an existing file (perhaps downloaded) as follows:
1. File | New Calendar
2. Browse for file
3. pick an existing .ics file, click 'save'

Actual Results:  
1. File menu has New file but no Open file or subscribe remote file or import
file or export file, or publish file.
2. File picker title & button say 'save', but calendar is not loaded yet to save.
3. File picker gives Warning:  <file.ics> already exists.  Do you want to
replace it?

Expected Results:  
1. File menu has New file, Open file, subscribe remote file, import file, export
file, publish file, ...
2. File picker title and button say 'open'.
3. File picker gives no warning about an existing file.

Comment 1

[gekacheka]

Attachment: content patch to calendar.xul, calendarManager.js, localCalDialog.js&xul, menuOverlay.xul

calendarManager.js:
  launchAddCalendarDialog:
     rename to launchNewOrOpenCalendarDialog
     add third parameter: aMode, either "new" or "open"
     set mode from aMode
  launchNewCalendarDialog
     calls launchNewOrOpenCalendarDialog with aMode "new"
  launchOpenCalendarDialog
     calls launchNewOrOpenCalendarDialog with aMode "open"

localCalDialog.js
  accept mode "open" as well as "new" or "edit
  If mode is "open", init file picker with modeOpen, title "Open"

localCalDialog.xul
  add data for "title.open"

calendar.xul, sunbird calendar.xul:
  mod new_local_calendar_command to call calManager.launchNewCalendarDialog
  add open_local_calendar_command calls calManager.launchOpenCalendarDialog

menuOverlay.xul, sunbird menuOverlay.xul
  File Menu
    leave New Event and New Task at top of File menu 
      (easy for new users to find and first thing for them to try)
    separator for add calendar commands:
      After New Calendar File, add Open Calendar File
      Move Subscribe to Remote Calendar into this group (was in Tools menu)
    separator for import into calendar commands (near similar Open/Subscribe)
      Move Import File into this group 
    separator output from calendar commands
      Move export, email, publish, and print into this group.
    separator for window commands
      close calendar (really window/application) command
 Tools Menu:
   remove commands moved to file menu
   rename id from tasksMenu to menu_Tools like others.

Comment 2

[gekacheka]

Attachment: text patch, all locales: calendar.dtd, calendar.properties, menuOverlay.dtd

calendar.dtd
  Rename Add New Calendar 
      to New Calendar File
  Add	Open Calendar File
  Adding "file" emphasizes these are for a (local) file, not a URL,
    similar to the browser Open File vs. Open Location.

calendar.properties
  Add "New" for the new file dialog.

menuOverlay.dtd
  Rename New Calendar
      to New Calendar File
  Add	Open Calendar File

  Add ellipses ... after commands that open dialogs

  Make tools menu access key alt 'T' like in Firebird and Thunderbird.
    ('T' was tasks menu, which is no longer used.)

Comment 3

[gekacheka]

Comment on attachment 159524 [details] [diff] [review]
content patch to calendar.xul, calendarManager.js, localCalDialog.js&xul, menuOverlay.xul

tested with SB0.2 (moz1.8), Moz1.7.3 in en-US: 
  all commands appear in menus.
  New Calendar File creates file with new name.
  Open Calendar File accepts existing file without old 'exists' warning.

Comment 4

[gekacheka]

Attachment: update 159524: organize menu, implement open calendar

see comment #1

Comment 5

[gekacheka]

Attachment: update 159525: all locales add 'New', 'Open'; add '...' to dialog commands

See comment #2
(sorry, 159525 looks incomplete)

Comment 6

[Mostafa Hosseini]

Comment on attachment 161878 [details] [diff] [review]
update 159524: organize menu, implement open calendar

One calendar.server.dialog.title.new duplications and several
calendar.new.file.label dupes.

Comment 7

[Mostafa Hosseini]

Comment on attachment 161878 [details] [diff] [review]
update 159524: organize menu, implement open calendar

The previous comment was for the other patch, sorry.
For this one I see two uses of launchAddCalendarDialog in calendarManager.js
that haven't been converted. These may have been added after the patch was made
so I'll investigate.

Comment 8

[gekacheka]

Attachment: calendarManager.js: fix 2 missed launchAddCalendarDialog -> launchOpenCalendarFileDialog

You're right.  It looks like they should be converted to
launchOpenCalendarFileDialog (if user clicked on it, it must already exist, so
can't be new).	They are in code that hasn't worked for me (on w2k), so my
testing didn't catch it.

Comment 9

[Mostafa Hosseini]

Comment on attachment 161878 [details] [diff] [review]
update 159524: organize menu, implement open calendar

-     <menu id="tasksMenu"
+     <menu id="menu_Tools"

Just note that tasksMenu was chosen to make possible adding all the tools that
come with tasksOverlay.xul in case it is being included.

Comment 10

[Mostafa Hosseini]

Attachment: Parts excluded from check-in

All reviewed patches have been checked in excluding parts which seemed to be
unnecessary. They are provided in this patch.

Comment 11

[Mostafa Hosseini]

This is fixed in CVS now.
Again, thanks for the great improvement.

Comment 12

[Simon Paquet [:sipaq]]

This patch seems to have brought up bug 268202. On Firefox the Tools menu in
calendar doesn't show anything anymore. On Sunbird it only shows the JS Console
and the Options menuitem. Is this intended behaviour?

If yes, we should remove the tools menu for the firefox extension.

Comment 13

[gekacheka]

I suggest adding the JavaScript console command if that is possible.
It will make it easier for users and developers to debug problems.
It is not obvious to users to try the JavaScript console of the underyling
browser or thunderbird when reporting bugs, and is an extra step for developers.

Wasn't there a Password Manager there at one point?

It could also be helpful to add Options there on Thunderbird and Firefox so
users don't have to find the Options in the extensions of the underlying
platform.  (Edit | Preferences may be inconsistent with FF/TB's Tools | Options,
so harder to remember.)

Comment 14

[Mostafa Hosseini]

Any helpful options are welcome especially Javascript Console.
Just note that the addition should be supported on Mozilla Suite, firefox and
thunderbird, even if done with if-else blocks.

Comment 15

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!