Closed Bug 260563 Opened 20 years ago Closed 20 years ago

Add space before parenthesis in label/value accesskey case

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: aaronlev, Assigned: aaronlev)

Details

Attachments

(1 file)

When an accesskey character is not in the label, the accesskey is appended in
parenthesis after the label.

It looks better when there is a space before the parenthesis. This is currently
not the case when the label uses a value attribute (as opposed to text node
children).
Attachment #159487 - Flags: superreview?(neil.parkwaycc.co.uk)
Comment on attachment 159487 [details] [diff] [review]
Add space before (x) if necessary

Trivial patch
Attachment #159487 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview?(dbaron)
Comment on attachment 159487 [details] [diff] [review]
Add space before (x) if necessary

Before !isspace, either add "mTitle.IsEmpty() ||" or "!mTitle.IsEmpty() &&". 
Your choice, but don't call Last on an empty string.  (I think the latter
probably makes more sense, though.)
Attachment #159487 - Flags: superreview?(dbaron) → superreview+
Comment on attachment 159487 [details] [diff] [review]
Add space before (x) if necessary

Okay, will post new patch if requested to do so.
Attachment #159487 - Flags: review?(pkwarren)
Attachment #159487 - Flags: review?(pkwarren) → review+
Enter passphrase for key '/home/aleventhal/.ssh/id_dsa':
Checking in nsTextBoxFrame.cpp;
/cvsroot/mozilla/layout/xul/base/src/nsTextBoxFrame.cpp,v  <--  nsTextBoxFrame.cpp
new revision: 1.75; previous revision: 1.74
done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Component: Keyboard: Navigation → User events and focus handling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: