260569 - http channel's cache entry (nsICachingChannel::cacheToken) unavailable after onstoprequest

Status: RESOLVED WORKSFORME

(Core :: Networking: HTTP, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

After onstoprequest has fired, the http channel releases mCacheEntry. this would
probably be mostly OK, unfortunately this means that a synchronous open() will
(in some cases) not allow accessing the cache entry at all.

<darin> i think it may be ok to call mCacheEntry->MarkValid in place of
CloseCacheEntry in HTTP::OnStopRequest

Comment 1

[Josh Aas]

Anyone know if this is still an issue?

Comment 2

[Josh Matthews [:jdm]]

Given that we call CloseCacheEntry in OnStopRequest, and GetCacheToken QIs mCacheEntry, the answer is yes.

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Given that we've gone almost a decade with this "bug," and fixing it is likely to interfere with cache performance work, perhaps we should WONTFIX it or look at it after the cache performance work is done, to see if it will even be feasible to fix?

AFAICT, this would most likely affect XHR, but XHR has workarounds for it already.

Comment 4

[Jason Duell]

IIRC we can't fix this without also fixing the fact that other cache readers of the same entry currently get blocked until we release the entry.  That's presumably why we take care to release it in OnStopRequest.

I don't see a specific use request for this ATM, so...