260605 - Registering new accesskey should clear old entry for same element

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Aaron Leventhal]

When an accesskey changes dynamically via JavaScript, the old accesskey for that
element should no longer work to trigger it.

Comment 1

[Aaron Leventhal]

Attachment: Testcase

Press Alt+Q to trigger checkbox.
After that, the accesskey is changed to 'B'
Alt+B works now, but so does Alt+Q which shoudln't.

The problem is that esm:RegisterAccessKey() doesn't look for the element in the
hash table and just change that entry if it exists. It adds another entry
pointing to the same element. It would require doing a hash table lookup by key
rather than value.

UnregisterAccesskey doesn't help because it isn't called. By the time
AttributeChanged() knows to call RegisterAccessKey the old accesskey value is
gone.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Isn't this a matter of having SetAttr() unregister the accesskey before setting
the attribute (the way this is done for HTML)?

Comment 3

[Aaron Leventhal]

I was wrong about several things:
- Unregistering does work, just not when the accesskey is stored on an anonymous
label such as for a radio button or checkbox
- It's handled in nsXULElement::SetAttr() and nsXULElement::UnregisterAccessKey()

Patch in bug 260527 fixes this.

Comment 4

[Aaron Leventhal]

Fixed by checkin to bug 260527