Closed Bug 260744 Opened 15 years ago Closed 11 years ago

"Opening file" dialog could use more precise instructions

Categories

(Thunderbird :: Mail Window Front End, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: lapsap7+mz, Assigned: mkmelin)

Details

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3

When we double-click on an attachment, eg an Excel file, the "Open file" dialog
appears.  If we then choose the check-box whose label is
"Do this automatically for files like this from now on"
one more sentence will appear underneath it.  In this sentence, the word
"Downloads" should have to be "Attachments".

Reason: "Downloads" section only exists in FireFox, not in ThunderBird.

Reproducible: Always
Steps to Reproduce:
The offending strings for Win, Mac and Linux:

"Settings can be changed in the Downloads section of Tools, Options."
"Settings can be changed in the Downloads section of Thunderbird, Preferences."
"Settings can be changed in the Downloads section of Edit, Preferences."

are defined as settingsChange.label, settingsChangeMac.label and
settingsChangeUnix.label in unknownContentType.dtd. These definitions are used
in unknownContentType.xul.

 This code appears to be used in both Firefox and Thunderbird, but uses
Firefox-specific terminology, as noted by the reporter.
QA Contact: front-end
I see "Settings can be changed in the Content section of Thunderbird, Preferences." in Mac.

WFM as in http://mxr.mozilla.org/seamonkey/source/toolkit/locales/en-US/chrome/mozapps/downloads/settingsChange.dtd#41
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME
Yes, it's now written as "Content" in Windows platforms as well.  Maybe in Mac that section is called "Content", but in Windows it's called "Attachments".  So this is still wrong and as matter of better and user-friendly GUI, I have to reopen the bug.

The correct word have to be "Attachments".
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
This was fixed on trunk in bug 395317 with a generic string "Settings can be changed in &brandShortName;'s Preferences" for toolkit. Firefox then overrides this with an application specific path at http://mxr.mozilla.org/mozilla/source/browser/locales/en-US/chrome/overrides/settingsChange.dtd#41. Thunderbird should perhaps do the same.

Fixing this bug in Thunderbird 2.0 would require l10n string changes, and I don't think that is very likely.
Hardware: PC → All
Version: unspecified → 2.0
Assignee: mscott → mkmelin+mozilla
Status: REOPENED → NEW
Target Milestone: --- → Thunderbird 3
Status: NEW → ASSIGNED
Summary: "Opening file" dialog uses a wrong word → "Opening file" dialog could use more precise instructions
Target Milestone: Thunderbird 3 → Thunderbird 3.0b3
Attached patch proposed fixSplinter Review
Attachment #362958 - Flags: review?(philringnalda)
Comment on attachment 362958 [details] [diff] [review]
proposed fix

Looks fine, thanks. 

However, so far except for the randomness in the themes, we seem to be doing pretty well at following suite/ policy of keeping all the % things together at the top of the jar, instead of browser/ policy of "um, wherever," so let's put this one at the top too.

Extra credit for deciding on a defensible statement of what our policy is on whether we do single spaces between the parts of overrides and overlays and content and style and skin, or line them up with the filenames :)
Attachment #362958 - Flags: review?(philringnalda) → review+
Version: 2.0 → Trunk
Lost me on defensible;)
Made it single space, and moved to top though.

Of course firefox's jar.mn is nicer, not having to put @AB_CD@ on each row, so if someone pokes around that the massive change could fix such inconsistencies at the same time.

changeset:   2146:869a616b491e
http://hg.mozilla.org/comm-central/rev/869a616b491e

->FIXED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.